From: Pieter Praet <pieter@praet.org>
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.
Date: Mon, 16 Jan 2012 12:17:03 +0100 [thread overview]
Message-ID: <87aa5nlwwg.fsf@praet.org> (raw)
In-Reply-To: <1325004434-24583-1-git-send-email-dme@dme.org>
On Tue, 27 Dec 2011 16:47:14 +0000, David Edmondson <dme@dme.org> wrote:
> The tags were coloured using text properties. Unfortunately that text
> (the header line) also has an overlay, which overrides the text
> properties. There's not point in applying text properties that will
> never be seen.
> ---
> emacs/notmuch-show.el | 8 ++------
> 1 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 8c9d846..24f0b40 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -221,10 +221,7 @@ indentation."
> (goto-char (notmuch-show-message-top))
> (if (re-search-forward "(\\([^()]*\\))$" (line-end-position) t)
> (let ((inhibit-read-only t))
> - (replace-match (concat "("
> - (propertize (mapconcat 'identity tags " ")
> - 'face 'notmuch-tag-face)
> - ")"))))))
> + (replace-match (concat "(" (mapconcat 'identity tags " ") ")"))))))
>
> (defun notmuch-show-clean-address (address)
> "Try to clean a single email ADDRESS for display. Return
> @@ -278,8 +275,7 @@ message at DEPTH in the current thread."
> " ("
> date
> ") ("
> - (propertize (mapconcat 'identity tags " ")
> - 'face 'notmuch-tag-face)
> + (mapconcat 'identity tags " ")
> ")\n")
> (overlay-put (make-overlay start (point)) 'face 'notmuch-message-summary-face)))
>
> --
> 1.7.7.3
Alas, those text properties actually *were* effective (and I liked them :)
- Before: http://i.imgur.com/Ipxnm.png
- After: http://i.imgur.com/XcaaF.png
Peace
--
Pieter
next prev parent reply other threads:[~2012-01-16 11:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-27 16:47 [PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode' David Edmondson
2011-12-28 3:29 ` Austin Clements
2011-12-28 12:42 ` Xavier Maillard
2011-12-28 20:09 ` Jameson Graef Rollins
2011-12-28 21:51 ` Xavier Maillard
2011-12-28 12:43 ` Xavier Maillard
2012-01-16 3:03 ` David Bremner
2012-01-16 11:17 ` Pieter Praet [this message]
2012-01-16 11:22 ` David Edmondson
2012-01-16 11:44 ` Pieter Praet
2012-01-16 20:51 ` Aaron Ecay
2012-01-16 21:24 ` Jani Nikula
2012-01-16 22:21 ` David Bremner
2012-01-17 7:22 ` David Edmondson
2012-01-17 12:05 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87aa5nlwwg.fsf@praet.org \
--to=pieter@praet.org \
--cc=dme@dme.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).