From: Pieter Praet <pieter@praet.org>
To: Tomi Ollila <tomi.ollila@iki.fi>,
Dmitry Kurochkin <dmitry.kurochkin@gmail.com>,
Ethan Glasser-Camp <glasse@cs.rpi.edu>
Cc: Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH] test: always report missing prereqs, independent of `--verbose' option
Date: Fri, 20 Jan 2012 01:33:31 +0100 [thread overview]
Message-ID: <87aa5jus9w.fsf@praet.org> (raw)
In-Reply-To: <87d3afuspp.fsf@praet.org>
On Fri, 20 Jan 2012 01:24:02 +0100, Pieter Praet <pieter@praet.org> wrote:
> [...]
> Most likely because "$test_subtest_missing_external_prereqs_" is only
> reset at the beginning of every test series, so if an Emacs-dependent
> subtest is skipped, all subsequent skipped subtests will report that
> dependency as well, even if they were skipped due to a missing vi :).
> [...]
That's not right at all.
"$test_subtest_missing_external_prereqs_" is reset at every invocation
of `test_begin_subtest', using `test_reset_state_'.
Apologies for the misinformation.
Peace
--
Pieter
next prev parent reply other threads:[~2012-01-20 0:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-16 17:16 [PATCH] Document the dependency on dtach in the test suite Ethan Glasser-Camp
2012-01-16 17:55 ` Dmitry Kurochkin
2012-01-18 12:19 ` [PATCH] test: always report missing prereqs, independent of `--verbose' option Pieter Praet
2012-01-18 13:53 ` Tomi Ollila
2012-01-20 0:24 ` Pieter Praet
2012-01-20 0:33 ` Pieter Praet [this message]
2012-02-21 3:27 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87aa5jus9w.fsf@praet.org \
--to=pieter@praet.org \
--cc=dmitry.kurochkin@gmail.com \
--cc=glasse@cs.rpi.edu \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).