From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id D5CCB429E5B for ; Mon, 23 Jan 2012 03:47:35 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.3 X-Spam-Level: X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NJ4qRtu6I5NC for ; Mon, 23 Jan 2012 03:47:35 -0800 (PST) Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 271BC429E54 for ; Mon, 23 Jan 2012 03:47:35 -0800 (PST) Received: from zancas.localnet (fctnnbsc36w-156034071197.pppoe-dynamic.High-Speed.nb.bellaliant.net [156.34.71.197]) (authenticated bits=0) by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id q0NBlOVF007284 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Mon, 23 Jan 2012 07:47:25 -0400 Received: from bremner by zancas.localnet with local (Exim 4.77) (envelope-from ) id 1RpIMu-0002TE-3i; Mon, 23 Jan 2012 07:47:24 -0400 From: David Bremner To: Justus Winter <4winter@informatik.uni-hamburg.de>, notmuch@notmuchmail.org Subject: Re: [PATCH] python: fix error handling In-Reply-To: <1327237776-18100-1-git-send-email-4winter@informatik.uni-hamburg.de> References: <87obtvc42c.fsf@zancas.localnet> <1327237776-18100-1-git-send-email-4winter@informatik.uni-hamburg.de> User-Agent: Notmuch/0.11+89~g85665a2 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Mon, 23 Jan 2012 07:47:24 -0400 Message-ID: <87aa5eabeb.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jan 2012 11:47:36 -0000 On Sun, 22 Jan 2012 14:09:35 +0100, Justus Winter <4winter@informatik.uni-hamburg.de> wrote: > Before 3434d1940 the return values of libnotmuch functions were > declared as c_void_p and the code checking for errors compared the > returned value to None, which is the ctypes equivalent of a NULL > pointer. Looks good to me as well. I pushed it to branch release. Could you make a NEWS patch against branch release (i.e. start 0.11.1) ? d