From: Jameson Graef Rollins <jrollins@finestructure.net>
To: David Edmondson <dme@dme.org>, Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end
Date: Mon, 23 Jan 2012 10:51:06 -0800 [thread overview]
Message-ID: <87aa5e1cdh.fsf@servo.finestructure.net> (raw)
In-Reply-To: <cunty3m2tj1.fsf@hotblack-desiato.hh.sledj.net>
[-- Attachment #1: Type: text/plain, Size: 647 bytes --]
On Mon, 23 Jan 2012 17:55:14 +0000, David Edmondson <dme@dme.org> wrote:
> On that basis, I hope no-one will complain if I fix them as a 'drive by'
> during another change...
Hrm. I don't think that follows. Unless the patch is already touching
that code, I would really prefer we continue to enforce that unrelated
changes go into separate patches.
There are plenty of other places in the code where we do use parens
around uninitialized variables. If you really want to remove them I
would prefer to see a patch to fixes them all at once. Doesn't seem
worth it to me, but everyone seems to be on an uncrustify kick recently,
so...
jamie.
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2012-01-23 18:51 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-17 18:05 show-mode message/thread archiving improvements Jameson Graef Rollins
2012-01-17 18:05 ` [PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two generally useful functions Jameson Graef Rollins
2012-01-17 18:05 ` [PATCH 2/6] emacs: break out thread navigation from notmuch-show-archive-thread Jameson Graef Rollins
2012-01-17 18:05 ` [PATCH 3/6] emacs: add message archiving functions Jameson Graef Rollins
2012-01-17 18:05 ` [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end Jameson Graef Rollins
2012-01-17 18:05 ` [PATCH 5/6] emacs: use pop-at-end functionality in show-archive-message-then-next function Jameson Graef Rollins
2012-01-17 18:05 ` [PATCH 6/6] emacs: modify the default show-mode key bindings for archiving Jameson Graef Rollins
2012-01-18 8:13 ` David Edmondson
2012-01-18 8:12 ` [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end David Edmondson
2012-01-18 8:47 ` Jameson Graef Rollins
2012-01-18 8:56 ` David Edmondson
2012-01-18 18:53 ` Jameson Graef Rollins
2012-01-17 18:43 ` [PATCH] emacs: fix archive thread/message function documentation Jameson Graef Rollins
2012-01-17 20:13 ` [PATCH 3/6] emacs: add message archiving functions Aaron Ecay
2012-01-17 20:18 ` Jameson Graef Rollins
2012-01-18 8:09 ` David Edmondson
2012-01-18 8:08 ` [PATCH 2/6] emacs: break out thread navigation from notmuch-show-archive-thread David Edmondson
2012-01-17 20:10 ` [PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two generally useful functions Aaron Ecay
2012-01-17 20:17 ` Jameson Graef Rollins
2012-01-17 20:57 ` Aaron Ecay
2012-01-18 8:14 ` David Edmondson
2012-01-18 8:06 ` David Edmondson
2012-01-17 20:09 ` show-mode message/thread archiving improvements Aaron Ecay
2012-01-23 8:33 ` Jameson Graef Rollins
2012-01-23 8:34 ` [PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two more generally useful functions Jameson Graef Rollins
2012-01-23 8:34 ` [PATCH 2/6] emacs: break out thread navigation from notmuch-show-archive-thread Jameson Graef Rollins
2012-01-23 8:34 ` [PATCH 3/6] emacs: add message archiving functions Jameson Graef Rollins
2012-01-23 8:34 ` [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end Jameson Graef Rollins
2012-01-23 8:34 ` [PATCH 5/6] emacs: use pop-at-end functionality in show-archive-message-then-next function Jameson Graef Rollins
2012-01-23 8:34 ` [PATCH 6/6] emacs: modify the default show-mode key bindings for archiving Jameson Graef Rollins
2012-01-23 11:14 ` David Edmondson
2012-01-23 21:03 ` Xavier Maillard
2012-01-24 18:50 ` Tomi Ollila
2012-01-23 11:02 ` [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end David Edmondson
2012-01-23 17:39 ` Jameson Graef Rollins
2012-01-23 17:55 ` David Edmondson
2012-01-23 18:51 ` Jameson Graef Rollins [this message]
2012-01-23 11:01 ` [PATCH 3/6] emacs: add message archiving functions David Edmondson
2012-01-24 18:44 ` Tomi Ollila
2012-01-23 11:01 ` [PATCH 2/6] emacs: break out thread navigation from notmuch-show-archive-thread David Edmondson
2012-01-23 11:00 ` [PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two more generally useful functions David Edmondson
2012-01-25 0:06 ` Jameson Graef Rollins
2012-01-25 0:06 ` [PATCH v3 1/8] emacs: use search-next-thread to move to next thread in show mode Jameson Graef Rollins
2012-01-25 0:06 ` [PATCH v3 2/8] emacs: break up notmuch-show-archive-thread-internal into two more generally useful functions Jameson Graef Rollins
2012-01-25 0:06 ` [PATCH v3 3/8] emacs: break out thread navigation from notmuch-show-archive-thread Jameson Graef Rollins
2012-01-25 0:06 ` [PATCH v3 4/8] emacs: add message archiving functions Jameson Graef Rollins
2012-01-25 0:06 ` [PATCH v3 5/8] emacs: add option to show-next-{, open-}message functions to pop out to parent buffer if at end Jameson Graef Rollins
2012-01-25 0:06 ` [PATCH v3 6/8] emacs: use pop-at-end functionality in show-archive-message-then-next function Jameson Graef Rollins
2012-01-25 0:06 ` [PATCH v3 7/8] emacs: modify the default show-mode key bindings for archiving Jameson Graef Rollins
2012-01-25 0:06 ` [PATCH v3 8/8] emacs: fix show-previous-message doc string Jameson Graef Rollins
2012-01-25 10:53 ` David Edmondson
2012-01-25 10:53 ` [PATCH v3 7/8] emacs: modify the default show-mode key bindings for archiving David Edmondson
2012-01-25 10:52 ` [PATCH v3 6/8] emacs: use pop-at-end functionality in show-archive-message-then-next function David Edmondson
2012-01-25 10:51 ` [PATCH v3 5/8] emacs: add option to show-next-{, open-}message functions to pop out to parent buffer if at end David Edmondson
2012-01-25 10:50 ` [PATCH v3 4/8] emacs: add message archiving functions David Edmondson
2012-01-25 10:49 ` [PATCH v3 3/8] emacs: break out thread navigation from notmuch-show-archive-thread David Edmondson
2012-01-25 10:47 ` [PATCH v3 2/8] emacs: break up notmuch-show-archive-thread-internal into two more generally useful functions David Edmondson
2012-01-25 10:53 ` [PATCH v3 1/8] emacs: use search-next-thread to move to next thread in show mode David Edmondson
2012-01-31 3:28 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87aa5e1cdh.fsf@servo.finestructure.net \
--to=jrollins@finestructure.net \
--cc=dme@dme.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).