From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id A5651431FB6 for ; Sat, 28 Jan 2012 14:54:58 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.8 X-Spam-Level: X-Spam-Status: No, score=-0.8 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id devcb7IIggTr for ; Sat, 28 Jan 2012 14:54:58 -0800 (PST) Received: from mail-ee0-f53.google.com (mail-ee0-f53.google.com [74.125.83.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id F2436431FAE for ; Sat, 28 Jan 2012 14:54:57 -0800 (PST) Received: by eeke51 with SMTP id e51so1415724eek.26 for ; Sat, 28 Jan 2012 14:54:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=schoepe.org; s=google; h=from:to:subject:in-reply-to:references:user-agent:date:message-id :mime-version:content-type; bh=2Qv5lhDSBmTLDq6cJin/WtUqcXO20RRRbjgK1n3mM/k=; b=Y6gYYl5x65/y62CXxpEwIoEmQlK9Sjeml3wJtakhTl/76O4if5BQtRoWahAtsDUTDb tRajkX/ke8fJgs37di1g7pj1c9RTRUYUPfxPZmG2+XGiOjyVC3xfN5Qr0UkPRgrQzcdi PwqaFUGUs/t2W9m9FogOqy+h1uAYEvnimfAvg= Received: by 10.14.194.134 with SMTP id m6mr128000een.4.1327791296706; Sat, 28 Jan 2012 14:54:56 -0800 (PST) Received: from localhost (dslb-088-069-137-009.pools.arcor-ip.net. [88.69.137.9]) by mx.google.com with ESMTPS id t11sm23008596eea.10.2012.01.28.14.54.55 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 28 Jan 2012 14:54:55 -0800 (PST) From: Daniel Schoepe To: Dmitry Kurochkin , notmuch@notmuchmail.org Subject: Re: [PATCH v7 2/2] emacs: Tests for user-defined sections In-Reply-To: <87ipjv8mvn.fsf@gmail.com> References: <87d3ac8ta9.fsf@schoepe.localhost> <1327193689-6011-1-git-send-email-daniel@schoepe.org> <1327193689-6011-2-git-send-email-daniel@schoepe.org> <87y5sym31d.fsf@gmail.com> <87ehujqzu6.fsf@schoepe.localhost> <87ipjv8mvn.fsf@gmail.com> User-Agent: Notmuch/0.10.2+186~g93a0b67 (http://notmuchmail.org) Emacs/24.0.92.1 (x86_64-pc-linux-gnu) Date: Sat, 28 Jan 2012 23:54:38 +0100 Message-ID: <87aa57qvyp.fsf@schoepe.localhost> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Jan 2012 22:54:58 -0000 --=-=-= Content-Type: text/plain Hi Dmitry. On Sun, 29 Jan 2012 02:48, Dmitry Kurochkin wrote: > I only meant trailing whitespaces in test/emacs file in the lines added > by the patch. Trailing whitespaces in expected results are obviously > fine. Ah, okay. I fixed those with delete-trailing-whitespace, but then noticed that this also corrected some trailing whitespace in unrelated tests, reverted that and then forgot about the trailing whitespace in my tests by the time I responded. > I think splitting emacs tests based on -hello, -show and -search views > is a good idea. Splitting existing tests is out of scope of this > patch. But I think it may be a good opportunity to add a new file with > -hello tests. You're right; I'll do that if you find other flaws in your next review. Otherwise, I'll just put it in another patch. Cheers, Daniel --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJPJHyuAAoJEIaTAtce+Z+Jx78QAJPisZPcGRERql2bD1HI7q4e Tfi+zzHrLkjZQ/g1JTkCPfbVkVR78yakdK1tM8ZZPBs7jhjyT7GL9SGfn5Qdus2Z YdFwA/dhbvkPEHaeHYFUnemd790nKCxgfWdo4yi0hng4UDwaYBzDiZBY0Vrkcboy gIUW04GmOQRE242f2l2nQBgKLklFRtVZQtrOLDQWdq/BWwb+lCriLLBHwPzDIzP/ sAm/2hfmfzWf2xIYd7OBYxQ5gz9h/Ow85rO+fOb6fzy98FkIIaaXn2ic0xwGiffN ozo3TI9lYRbEkP8cI/DV3ZwYLqsMGp7We43iXu3YndPiqpF1ywAtLluhCx4jXbg8 LndmG4xJjsx3lPvFqMZORdnZFNYRXTh8CvA/5V9kdl3XUVgMpXBtwyonmtYao+4h oalkmonuhy9u2wrt82zS0Jc24Uez7wCNiz3OWgJzxImdsr5a+jXnDZU39Hu9pp5C G5NDaA0DxC5idi/+KXtVJdlQeufQs+QItrRfgpIlYsbHs1ga/Bz+ZXXM7ZVRdzLP yiW49RXoFOvnYxTaEgy3E5H4/nb1euYsYcDPBfJIMsgc93N5lbShIX4QaC+dHvFr It10ctYQ9PSN3qXJnTnD0qRh7q6c3ywwe/PLSlO+26ssr/iBIG0ap1XHkVljJoNZ MEDDKMOm90HalV0axY1A =t4Gq -----END PGP SIGNATURE----- --=-=-=--