From: Daniel Schoepe <daniel@schoepe.org>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH v7 2/2] emacs: Tests for user-defined sections
Date: Sat, 28 Jan 2012 23:54:38 +0100 [thread overview]
Message-ID: <87aa57qvyp.fsf@schoepe.localhost> (raw)
In-Reply-To: <87ipjv8mvn.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 855 bytes --]
Hi Dmitry.
On Sun, 29 Jan 2012 02:48, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> I only meant trailing whitespaces in test/emacs file in the lines added
> by the patch. Trailing whitespaces in expected results are obviously
> fine.
Ah, okay. I fixed those with delete-trailing-whitespace, but then
noticed that this also corrected some trailing whitespace in unrelated
tests, reverted that and then forgot about the trailing whitespace in my
tests by the time I responded.
> I think splitting emacs tests based on -hello, -show and -search views
> is a good idea. Splitting existing tests is out of scope of this
> patch. But I think it may be a good opportunity to add a new file with
> -hello tests.
You're right; I'll do that if you find other flaws in your next
review. Otherwise, I'll just put it in another patch.
Cheers,
Daniel
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2012-01-28 22:54 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <id:"1309379221-5617-1-git-send-email-daniel.schoepe@googlemail.com">
2011-07-07 22:53 ` [PATCH v4 0/2] emacs: User-defined sections in notmuch-hello Daniel Schoepe
2011-07-07 22:53 ` [PATCH v4 1/2] " Daniel Schoepe
2011-07-08 23:00 ` Michal Sojka
2011-07-08 23:13 ` Daniel Schoepe
2011-07-09 5:35 ` Michal Sojka
2011-07-09 17:07 ` Daniel Schoepe
2011-07-07 22:53 ` [PATCH v4 2/2] emacs: Tests for user-defined sections Daniel Schoepe
2011-07-09 18:03 ` [PATCH v5 0/2] emacs: User-defined sections in notmuch-hello Daniel Schoepe
2011-07-09 18:03 ` [PATCH v5 1/2] " Daniel Schoepe
2011-07-09 18:03 ` [PATCH v5 2/2] emacs: Tests for user-defined sections Daniel Schoepe
2011-07-11 10:32 ` [PATCH] emacs: NEWS entry " Daniel Schoepe
2011-08-14 16:55 ` [PATCH v5 0/2] emacs: User-defined sections in notmuch-hello Daniel Schoepe
2011-08-15 8:40 ` Michal Sojka
2011-10-10 13:39 ` [PATCH v6 " Daniel Schoepe
2011-10-10 13:39 ` [PATCH v6 1/2] " Daniel Schoepe
2011-11-24 13:54 ` David Bremner
2011-11-24 14:01 ` Daniel Schoepe
2011-11-24 15:43 ` Michal Sojka
2011-11-28 4:06 ` Dmitry Kurochkin
2011-11-28 7:57 ` Michal Sojka
2011-12-14 3:11 ` Dmitry Kurochkin
2011-12-14 12:55 ` Dmitry Kurochkin
2012-01-22 0:39 ` Daniel Schoepe
2012-01-22 0:54 ` [PATCH v7 " Daniel Schoepe
2012-01-22 0:54 ` [PATCH v7 2/2] emacs: Tests for user-defined sections Daniel Schoepe
2012-01-23 23:07 ` Dmitry Kurochkin
2012-01-28 21:30 ` Daniel Schoepe
2012-01-28 21:44 ` [PATCH v8 0/2] emacs: User-defined sections in notmuch-hello Daniel Schoepe
2012-01-28 21:44 ` [PATCH v8 1/2] " Daniel Schoepe
2012-01-28 21:44 ` [PATCH v8 2/2] emacs: Tests for user-defined sections Daniel Schoepe
2012-01-28 22:48 ` [PATCH v7 " Dmitry Kurochkin
2012-01-28 22:54 ` Daniel Schoepe [this message]
2011-10-10 13:39 ` [PATCH v6 " Daniel Schoepe
2011-10-13 14:09 ` [PATCH] emacs-hello: Do not calculate the count of the messages in Michal Sojka
2012-01-16 11:33 ` David Edmondson
2012-01-16 12:39 ` Daniel Schoepe
2012-01-16 10:59 ` [PATCH v6 0/2] emacs: User-defined sections in notmuch-hello David Edmondson
2012-01-16 11:13 ` Daniel Schoepe
2012-02-17 7:48 ` [PATCH v9 " Dmitry Kurochkin
2012-02-17 7:48 ` [PATCH v9 1/2] " Dmitry Kurochkin
2012-02-17 7:48 ` [PATCH v9 2/2] emacs: Tests for user-defined sections Dmitry Kurochkin
2012-02-17 14:48 ` [PATCH v10 0/2] emacs: User-defined sections in notmuch-hello Dmitry Kurochkin
2012-02-17 14:48 ` [PATCH v10 1/2] " Dmitry Kurochkin
2012-03-01 12:36 ` David Bremner
2012-03-01 14:57 ` Michal Sojka
2012-03-01 15:00 ` Dmitry Kurochkin
2012-03-07 19:53 ` Pieter Praet
2012-03-07 20:04 ` Daniel Schoepe
2012-03-07 20:11 ` David Bremner
2012-02-17 14:48 ` [PATCH v10 2/2] emacs: Tests for user-defined sections Dmitry Kurochkin
2012-02-18 22:10 ` [PATCH v10 0/2] emacs: User-defined sections in notmuch-hello Michal Sojka
2012-02-18 22:12 ` [PATCH] emacs-hello: Do not calculate the count of the messages in hidden sections Michal Sojka
2012-03-01 22:18 ` Mark Walters
2012-03-02 0:34 ` Daniel Schoepe
2012-03-02 0:36 ` Daniel Schoepe
2012-03-05 2:00 ` Dmitry Kurochkin
2012-03-10 14:23 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87aa57qvyp.fsf@schoepe.localhost \
--to=daniel@schoepe.org \
--cc=dmitry.kurochkin@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).