From: David Bremner <david@tethera.net>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/8] hex-escape: be more strict about the format while decoding
Date: Thu, 05 Apr 2012 08:59:36 -0300 [thread overview]
Message-ID: <87aa2qtmmv.fsf@zancas.localnet> (raw)
In-Reply-To: <87hawyxusp.fsf@nikula.org>
Jani Nikula <jani@nikula.org> writes:
> On Thu, 05 Apr 2012 08:33:23 -0300, David Bremner <david@tethera.net> wrote:
>>
>> > - if (len < 3)
>> > + if (!isxdigit ((unsigned char) p[1]) ||
>> > + !isxdigit ((unsigned char) p[2]))
>>
>> What happens if there are not two characters after the escape? Is this
>> relying on calling isxdigit on the null terminator?
>
> It is, and technically there's nothing wrong with that. Would you prefer
> explicit checks for '\0' in the if condition, for clarity? Or a comment
> about it?
I think a comment would do. Or the checks if you prefer.
next prev parent reply other threads:[~2012-04-05 11:59 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-31 22:17 [PATCH 0/8] batch tagging support: "notmuch tag --stdin" Jani Nikula
2012-03-31 22:17 ` [PATCH 1/8] hex-escape: (en|de)code strings to/from restricted character set Jani Nikula
2012-03-31 22:17 ` [PATCH 2/8] hex-escape: be more strict about the format while decoding Jani Nikula
2012-04-05 11:33 ` David Bremner
2012-04-05 11:49 ` Jani Nikula
2012-04-05 11:59 ` David Bremner [this message]
2012-03-31 22:17 ` [PATCH 3/8] hex-escape: add function to decode escaped string in-place Jani Nikula
2012-04-05 11:56 ` David Bremner
2012-04-05 12:00 ` Jani Nikula
2012-03-31 22:17 ` [PATCH 4/8] test/hex-xcode: new test binary Jani Nikula
2012-03-31 22:17 ` [PATCH 5/8] test/hex-escaping: new test for hex escaping routines Jani Nikula
2012-03-31 22:17 ` [PATCH 6/8] cli: add support for batch tagging operations to "notmuch tag" Jani Nikula
2012-04-02 17:51 ` Jameson Graef Rollins
2012-04-02 19:46 ` Jani Nikula
2012-04-02 17:54 ` Jameson Graef Rollins
2012-04-02 20:26 ` David Bremner
2012-04-02 20:42 ` Jameson Graef Rollins
2012-04-02 21:07 ` Jani Nikula
2012-04-02 21:20 ` Jameson Graef Rollins
2012-04-02 21:31 ` Jani Nikula
2012-04-02 21:43 ` Jameson Graef Rollins
2012-04-03 8:21 ` Jani Nikula
2012-04-03 22:51 ` Jameson Graef Rollins
2012-04-04 2:09 ` David Bremner
2012-04-04 7:55 ` Jameson Graef Rollins
2012-04-04 10:55 ` David Bremner
2012-03-31 22:17 ` [PATCH 7/8] test: add test for notmuch tag --stdin option Jani Nikula
2012-03-31 22:17 ` [PATCH 8/8] man: document " Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87aa2qtmmv.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).