[PATCH 1/2] Makefile.local: added checks for latest NEWS title

[PATCH 1/2] Makefile.local: added checks for latest NEWS title

[Tomi Ollila]

Added target `verify-version-news` which checks that the first line
in NEWS file has the following properties:
    First word is 'Notmuch'
    Second "word" matches the current version
    Rest of line is in format (201[2-9]-[01][0-9]-[0-3][0-9]
---

Tested by executing the following commands:
  make verify-version-news
  make verify-version-news VERSION=0.13
  make verify-version-news VERSION=0.12

 Makefile.local |   15 +++++++++++++++
 1 files changed, 15 insertions(+), 0 deletions(-)

diff --git a/Makefile.local b/Makefile.local
index 53b4a0d..1b34c00 100644
--- a/Makefile.local
+++ b/Makefile.local
@@ -220,6 +220,21 @@ verify-version-python: verify-version-components
 		 echo "Please edit version and $(PV_FILE) to have consistent versions." && false)
 	@echo "Good."
 
+.PHONY: verify-version-news
+verify-version-news: verify-version-components
+	@read notmuch version date < NEWS ;\
+	ev=0 ;\
+	echo -n "Checking that this is 'Notmuch' NEWS..." ;\
+	if [ "$$notmuch" = 'Notmuch' ]; then echo 'Good.' ;\
+	else echo 'No.'; ev=1; fi ;\
+	echo -n "Checking that NEWS version is $(VERSION)..." ;\
+	if [ "$$version" = '$(VERSION)' ]; then echo 'Good.' ;\
+	else echo 'No.'; ev=1; fi ;\
+	echo -n "Checking that NEWS date is in correct format..." ;\
+	case $$date in '('201[2-9]-[0-1][0-9]-[0-3][0-9]')') echo 'Good.' ;;\
+	*)   echo 'No.'; ev=1; esac ;\
+	if [ $$ev -ne 0 ]; then echo "Please edit NEWS file to have Notmuch header line in correct format."; false; fi
+
 .PHONY: verify-version-components
 verify-version-components:
 	@echo -n "Checking that $(VERSION) consists only of digits and periods..."
-- 
1.7.1

[PATCH 2/2] Makefile.local: added verify-version-news to verify-no-dirty-code deps.

[Tomi Ollila]

Added `verify-version-news` to the end of `verify-no-dirty-code`
dependencies so it is part of release testing checks.
---
Tested by executing the following commands:
  make verify-source-tree-and-version
  make verify-source-tree-and-version VERSION=0.13
  make verify-source-tree-and-version VERSION=0.12

 Makefile.local |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile.local b/Makefile.local
index 1b34c00..94a3a70 100644
--- a/Makefile.local
+++ b/Makefile.local
@@ -187,7 +187,7 @@ release-message:
 verify-source-tree-and-version: verify-no-dirty-code
 
 .PHONY: verify-no-dirty-code
-verify-no-dirty-code: verify-version-debian verify-version-python verify-version-manpage
+verify-no-dirty-code: verify-version-debian verify-version-python verify-version-manpage verify-version-news
 ifeq ($(IS_GIT),yes)
 	@printf "Checking that source tree is clean..."
 ifneq ($(shell git ls-files -m),)
-- 
1.7.1

Re: [PATCH 1/2] Makefile.local: added checks for latest NEWS title

[David Bremner]

Tomi Ollila <tomi.ollila@iki.fi> writes:

> Added target `verify-version-news` which checks that the first line
> in NEWS file has the following properties:
>     First word is 'Notmuch'
>     Second "word" matches the current version
>     Rest of line is in format (201[2-9]-[01][0-9]-[0-3][0-9]

I appreciate the effort, but I wonder if it is worth complicating the
build system further? I'm willing to be swayed either way.

d