From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH] test: fix compact backup / restore test
Date: Sat, 02 Nov 2013 11:56:58 -0300 [thread overview]
Message-ID: <87a9hmsvgl.fsf@zancas.localnet> (raw)
In-Reply-To: <m2li172avu.fsf@guru.guru-group.fi>
Tomi Ollila <tomi.ollila@iki.fi> writes:
> On Sat, Nov 02 2013, David Bremner <david@tethera.net> wrote:
>
>> It was looking in completely the wrong place for the backup and the
>> (test) xapian database. Unfortunately test_begin_subtest hides the
>> relevant errors.
>> ---
>
> LGTM. It took me a while noticing that also ${TEST_TMPDIR}
> was changed to ${MAIL_DIR}
Globally it makes me a bit nervous to be doing destructive operations on
${MAIL_DIR}, but that isn't specific to this patch. I wonder if it would
be worth globally replacing the variable with something like
TEST_MAIL_DIR just to make collision with user environment less
likely. Or maybe it's enough just to be careful to override MAIL_DIR.
d
next prev parent reply other threads:[~2013-11-02 14:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-02 0:01 [PATCH] test: fix compact backup / restore test David Bremner
2013-11-02 13:25 ` Tomi Ollila
2013-11-02 14:56 ` David Bremner [this message]
2013-11-03 12:30 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9hmsvgl.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).