unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH] test: fix test_require_external_prereq gdb in insert test
Date: Tue, 28 Oct 2014 19:15:50 +0100	[thread overview]
Message-ID: <87a94g2h7t.fsf@maritornes.cs.unb.ca> (raw)
In-Reply-To: <1414518754-16344-1-git-send-email-jani@nikula.org>

Jani Nikula <jani@nikula.org> writes:

> You need to actually check the return value. Limit the missing deps
> part to subtests requiring gdb.

For me, on a system without gdb, the current version looks like

T070-insert: Testing "notmuch insert"
 missing prerequisites: gdb(1)
 SKIP   all tests in T070-insert

This seems OK to me?

Of course you're right that moving it forward to only skip the gdb
requiring tests is the right thing to do, and in that setting having a
skipped message for all 10 skipped tests is a bit ugly. OTOHO your
version doesn't give any output at all, which seems not perfect either.

  reply	other threads:[~2014-10-28 18:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-28 17:52 [PATCH] test: fix test_require_external_prereq gdb in insert test Jani Nikula
2014-10-28 18:15 ` David Bremner [this message]
2014-10-28 19:43   ` Jani Nikula
2014-10-28 20:56     ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a94g2h7t.fsf@maritornes.cs.unb.ca \
    --to=david@tethera.net \
    --cc=jani@nikula.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).