unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH] test: make it possible to have multiple corpora
Date: Sun, 11 Sep 2016 15:37:03 -0300	[thread overview]
Message-ID: <87a8fep9kg.fsf@zancas.localnet> (raw)
In-Reply-To: <8737l6warg.fsf@nikula.org>

Jani Nikula <jani@nikula.org> writes:

>
> Even for the *one* message in the referenced patch, I don't know where I
> would put it as a message file. I worked around the issue by using a
> here document (which you objected to), but it's a general problem. If
> there's an issue someone sees, we can't just shove the message (or a set
> of messages) that reproduces the issue under corpus, because it would
> screw up all the other tests. There needs to be some other place. This
> seemed like a generic approach to the problem.
>
> I could also imagine a shell helper function to add a single message
> from somewhere under corpora to the db for testing. For some cases, it
> might be more readable than using add_message. (And for my case, it's
> impossible to use add_message because I need a broken message.)
>

OK, I didn't understand the combination of these two problems. In that
case, the change makes sense to me.

d

      reply	other threads:[~2016-09-11 18:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-11 16:03 [PATCH] test: make it possible to have multiple corpora Jani Nikula
2016-09-11 17:29 ` David Bremner
2016-09-11 18:29   ` Jani Nikula
2016-09-11 18:37     ` David Bremner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a8fep9kg.fsf@zancas.localnet \
    --to=david@tethera.net \
    --cc=jani@nikula.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).