unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Florian Klink <flokli@flokli.de>, notmuch@notmuchmail.org
Cc: Andreas Rammhold <andreas@rammhold.de>, Florian Klink <flokli@flokli.de>
Subject: Re: [PATCH v2 1/2] python: open messages in binary mode
Date: Mon, 02 Oct 2017 08:04:31 -0300	[thread overview]
Message-ID: <87a8193j5s.fsf@tethera.net> (raw)
In-Reply-To: <20170924123612.26679-1-flokli@flokli.de>

Florian Klink <flokli@flokli.de> writes:

> currently, notmuch's get_message_parts() opens the file in text mode and passes
> the file object to email.message_from_file(fp). In case the email contains
> UTF-8 characters, reading might fail inside email.parser with the following exception:
>

merged series to master. Thanks for the fix. BTW, I noticed the bug only
happens with python3.

d

  parent reply	other threads:[~2017-10-02 11:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-24 21:30 [PATCH] python: open messages in binary mode Florian Klink
2017-08-24 22:11 ` David Bremner
2017-08-25  6:08   ` Gaute Hope
2017-08-25 10:18     ` Florian Klink
2017-09-24 12:36   ` [PATCH v2 1/2] " Florian Klink
2017-09-24 12:36     ` [PATCH v2 2/2] T390-python: add test for get_message_parts and special characters Florian Klink
2017-10-02 11:04     ` David Bremner [this message]
2017-10-02 11:39       ` [PATCH v2 1/2] python: open messages in binary mode Florian Klink
2017-10-05 15:50         ` Tomi Ollila

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a8193j5s.fsf@tethera.net \
    --to=david@tethera.net \
    --cc=andreas@rammhold.de \
    --cc=flokli@flokli.de \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).