From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david@tethera.net>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 00D606DE0225
 for <notmuch@notmuchmail.org>; Sun, 26 Aug 2018 04:30:48 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: 0.001
X-Spam-Level: 
X-Spam-Status: No, score=0.001 tagged_above=-999 required=5 tests=[AWL=0.012, 
 SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id SJafcVFKfizP for <notmuch@notmuchmail.org>;
 Sun, 26 Aug 2018 04:30:47 -0700 (PDT)
Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
 by arlo.cworth.org (Postfix) with ESMTPS id E1AE26DE021C
 for <notmuch@notmuchmail.org>; Sun, 26 Aug 2018 04:30:46 -0700 (PDT)
Received: from remotemail by fethera.tethera.net with local (Exim 4.89)
 (envelope-from <david@tethera.net>)
 id 1fttFi-00017w-A1; Sun, 26 Aug 2018 07:30:42 -0400
Received: (nullmailer pid 1238 invoked by uid 1000);
 Sun, 26 Aug 2018 11:30:41 -0000
From: David Bremner <david@tethera.net>
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH v1 1/1] emacs: Kill the stderr buffer when an async
 process completes
In-Reply-To: <20180809205434.34404-1-dme@dme.org>
References: <m27evib3ny.fsf@dme.org> <20180809205434.34404-1-dme@dme.org>
Date: Sun, 26 Aug 2018 08:30:41 -0300
Message-ID: <87a7p9pdpa.fsf@tethera.net>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sun, 26 Aug 2018 11:30:48 -0000

David Edmondson <dme@dme.org> writes:
>  
> +(defun notmuch-start-notmuch-error-sentinel (proc event)
> +  (let* ((err-file (process-get proc 'err-file))
> +	 (err-buffer (or (process-get proc 'err-buffer)
> +			 (find-file-noselect err-file))))
Is the second case here (find-file-noselect) for the non-make-process
code path, or something else? It might help to have a comment.
> +    (when err-buffer (kill-buffer err-buffer))))
> +