From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: David Bremner <david@tethera.net>,
Notmuch Mail <notmuch@notmuchmail.org>,
bug-gnu-emacs@gnu.org
Subject: Re: notmuch-emacs: avoiding deprecated message-default-charset
Date: Sun, 21 Apr 2019 15:25:46 -0400 [thread overview]
Message-ID: <87a7gjw479.fsf@fifthhorseman.net> (raw)
In-Reply-To: <874l6re7zh.fsf@tethera.net>
[-- Attachment #1: Type: text/plain, Size: 1704 bytes --]
On Sun 2019-04-21 11:41:22 -0300, David Bremner wrote:
> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
>
>> When i'm building notmuch in a debian environment with emacs
>> 1:26.1+1-3.2, i notice the following deprecation warnings:
>>
>> In notmuch-maildir-setup-message-for-saving:
>> emacs/notmuch-maildir-fcc.el:172:31:Warning: ‘message-default-charset’ is an
>> obsolete variable (as of 26.1); The default charset comes from the
>> language environment
>>
>> I'm not enough of an emacs guru to know the right way to avoid this
>> warning, but i'm hoping that someonen else can take a stab at it, since
>> extraneous warnings make it easier to ignore real problems.
>
> Good question. I looked at message.el in emacs master and it
>
> 1) Obsoletes message-default-charset as in 26.1
> 2) Still uses it in exactly the construction we do.
interesting, thanks for digging that up.
> I'm not sure if it's exactly a reportable bug in emacs, but it is a bit
> annoying.
seems reportable, if not exactly high-severity. what does upstream
expect downstream users of message-default-charset to do? I'm
(trying to) forward this to the emacs upstream bugtracker; maybe we can
get guidance from them on what to do.
> There is a variable byte-compile-not-obsolete-vars that (probably) can
> be used to suppress that warning, but it's not clear that's a good
> idea (we currently do something similar for Xapian obsolescence warnings
> that we can't fix).
I would generally try to avoid that kind of a bypass, because i tend to
think that warnings are reasonable to look out for and try to fix before
they become real problems.
--dkg
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
next prev parent reply other threads:[~2019-04-21 21:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-20 20:00 notmuch-emacs: avoiding deprecated message-default-charset Daniel Kahn Gillmor
2019-04-21 14:41 ` David Bremner
2019-04-21 19:25 ` Daniel Kahn Gillmor [this message]
2019-04-21 22:05 ` bug#35370: " Noam Postavsky
2019-04-22 1:55 ` Daniel Kahn Gillmor
2019-04-22 6:33 ` Eli Zaretskii
2019-04-22 14:21 ` Daniel Kahn Gillmor
2019-04-22 15:37 ` Eli Zaretskii
2019-04-22 20:51 ` [PATCH] emacs: drop use of message-default-charset Daniel Kahn Gillmor
2019-04-22 21:23 ` Tomi Ollila
2019-05-07 9:38 ` David Bremner
2019-05-07 12:26 ` bug#35370: notmuch-emacs: avoiding deprecated message-default-charset Noam Postavsky
2019-05-07 14:36 ` Eli Zaretskii
2019-05-09 18:33 ` Lars Ingebrigtsen
2019-05-10 5:32 ` Eli Zaretskii
2019-05-10 10:45 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7gjw479.fsf@fifthhorseman.net \
--to=dkg@fifthhorseman.net \
--cc=bug-gnu-emacs@gnu.org \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).