From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 109606DE0286 for ; Sun, 15 Sep 2019 17:05:16 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -1.66 X-Spam-Level: X-Spam-Status: No, score=-1.66 tagged_above=-999 required=5 tests=[AWL=0.841, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RcdmkIUxZJq0 for ; Sun, 15 Sep 2019 17:05:14 -0700 (PDT) Received: from che.mayfirst.org (che.mayfirst.org [162.247.75.118]) by arlo.cworth.org (Postfix) with ESMTPS id CF83E6DE023C for ; Sun, 15 Sep 2019 17:05:13 -0700 (PDT) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019; t=1568592312; h=from : to : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=Ifny77/T1TG9RwJvhiiiYVirpyZB/4jSnIjnEySbdc0=; b=WPGxoFxiVhsjeoOZfdKKqgaM9+C8OZO9ohCLP1cLabGFh/0KkR9bhchD 11hejOHgIlrzQY1QuE7OncoE8FSPAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019rsa; t=1568592312; h=from : to : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=Ifny77/T1TG9RwJvhiiiYVirpyZB/4jSnIjnEySbdc0=; b=OXpLN1yr8nRZ4y06TPqZAZz77Mu8ZdTb888AjX4cvLUvohv75Mgg4nII HqMzo0H3FGPkow/quMiUes31U5eAqkjI/daQIYXdTMLQ99PfneAFOSuKkg gTDvvch5NvMhP1fp1PYw46XBeHeYq3V6o5FxLurz/FyG/kYHewrozMalrA KzD60DvmBy5g4bwR7r5H0THeixLtKUoXBlT5vUoZeudfTrwFF7WpHhfQH/ gNH4AtH84iJvTt6iqzCW4cRiDUD6EiuKt3Gq/2aqKyCg5sBoE/XaNkg9mP AjpmYOeU78I+Dt9Qh3L9imS5gFWnN1jC337K4mrFZr2eHuDhK/EAcQ== Received: from fifthhorseman.net (unknown [IPv6:2001:470:1f07:60d:c41:39ff:fef3:974f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by che.mayfirst.org (Postfix) with ESMTPSA id 2CD8CF9A6; Sun, 15 Sep 2019 20:05:10 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id 2EA782036F; Sun, 15 Sep 2019 19:09:39 -0400 (EDT) From: Daniel Kahn Gillmor To: Tomi Ollila , Notmuch Mail Subject: Re: [PATCH v5 2/4] util/repair: identify and repair "Mixed Up" mangled messages In-Reply-To: References: <87ftky104a.fsf@fifthhorseman.net> <20190915073845.12868-1-dkg@fifthhorseman.net> Autocrypt: addr=dkg@fifthhorseman.net; prefer-encrypt=mutual; keydata= mDMEXEK/AhYJKwYBBAHaRw8BAQdAr/gSROcn+6m8ijTN0DV9AahoHGafy52RRkhCZVwxhEe0K0Rh bmllbCBLYWhuIEdpbGxtb3IgPGRrZ0BmaWZ0aGhvcnNlbWFuLm5ldD6ImQQTFggAQQIbAQUJA8Jn AAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBMS8Lds4zOlkhevpwvIGkReQOOXGBQJcQsbzAhkB AAoJEPIGkReQOOXG4fkBAO1joRxqAZY57PjdzGieXLpluk9RkWa3ufkt3YUVEpH/AP9c+pgIxtyW +FwMQRjlqljuj8amdN4zuEqaCy4hhz/1DbgzBFxCv4sWCSsGAQQB2kcPAQEHQERSZxSPmgtdw6nN u7uxY7bzb9TnPrGAOp9kClBLRwGfiPUEGBYIACYWIQTEvC3bOMzpZIXr6cLyBpEXkDjlxgUCXEK/ iwIbAgUJAeEzgACBCRDyBpEXkDjlxnYgBBkWCAAdFiEEyQ5tNiAKG5IqFQnndhgZZSmuX/gFAlxC v4sACgkQdhgZZSmuX/iVWgD/fCU4ONzgy8w8UCHGmrmIZfDvdhg512NIBfx+Mz9ls5kA/Rq97vz4 z48MFuBdCuu0W/fVqVjnY7LN5n+CQJwGC0MIA7QA/RyY7Sz2gFIOcrns0RpoHr+3WI+won3xCD8+ sVXSHZvCAP98HCjDnw/b0lGuCR7coTXKLIM44/LFWgXAdZjm1wjODbg4BFxCv50SCisGAQQBl1UB BQEBB0BG4iXnHX/fs35NWKMWQTQoRI7oiAUt0wJHFFJbomxXbAMBCAeIfgQYFggAJhYhBMS8Lds4 zOlkhevpwvIGkReQOOXGBQJcQr+dAhsMBQkB4TOAAAoJEPIGkReQOOXGe/cBAPlek5d9xzcXUn/D kY6jKmxe26CTws3ZkbK6Aa5Ey/qKAP0VuPQSCRxA7RKfcB/XrEphfUFkraL06Xn/xGwJ+D0hCw== Date: Sun, 15 Sep 2019 19:09:38 -0400 Message-ID: <87a7b517il.fsf@fifthhorseman.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Sep 2019 00:05:16 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sun 2019-09-15 23:26:59 +0300, Tomi Ollila wrote: > On Sun, Sep 15 2019, Daniel Kahn Gillmor wrote: > >> This patch implements a functional identification and repair process > > If there is going to be more versions, then the above could be changed > to either=20 > > 1) This commit implements... > > or just > > 2) Implement a functional ... > >> for "Mixed Up" MIME messages as described in >> https://tools.ietf.org/html/draft-dkg-openpgp-pgpmime-message-mangling-0= 0#section-4.1 >> >> The detection test is not entirely complete, in that it does not >> verify the contents of the latter two message subparts, but this is >> probably safe to skip, because those two parts are unlikely to be >> readable anyway, and the only part we are effectively omitting (the >> first subpart) is guaranteed to be empty anyway, so its removal can be >> reversed if you want to do so. I've left FIXMEs in the code so that >> anyone excited about adding these additional checks can see where to >> put them in. >> >> I'll use this functionality in the next two patches. > > If there is going to be more versions, then the above line could be remov= ed... > > (as committed changes are not "patches" ...) I concur with (and appreciate) your terminological pedantry. the revision on my gitlab branch has adopted your suggestions, but i don't want to burden the list with another revision right now. hopefully this change to the commit message won't block adoption -- anyone merging the series should feel free to adjust the commit message as Tomi recommends. --dkg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQTJDm02IAobkioVCed2GBllKa5f+AUCXX7EsgAKCRB2GBllKa5f +P/CAQDXpY3qx+KPAvZLgaqOzqaV/2GGv6d0mCHMPH6rg0R+WQD+IaTuheyi2tFp BIUxpitOG19ZEmDhAyRY3SuqFgqHIwU= =pZeU -----END PGP SIGNATURE----- --=-=-=--