From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH v5 2/4] util/repair: identify and repair "Mixed Up" mangled messages
Date: Sun, 15 Sep 2019 19:09:38 -0400 [thread overview]
Message-ID: <87a7b517il.fsf@fifthhorseman.net> (raw)
In-Reply-To: <m25zlti9v0.fsf@guru.guru-group.fi>
[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]
On Sun 2019-09-15 23:26:59 +0300, Tomi Ollila wrote:
> On Sun, Sep 15 2019, Daniel Kahn Gillmor wrote:
>
>> This patch implements a functional identification and repair process
>
> If there is going to be more versions, then the above could be changed
> to either
>
> 1) This commit implements...
>
> or just
>
> 2) Implement a functional ...
>
>> for "Mixed Up" MIME messages as described in
>> https://tools.ietf.org/html/draft-dkg-openpgp-pgpmime-message-mangling-00#section-4.1
>>
>> The detection test is not entirely complete, in that it does not
>> verify the contents of the latter two message subparts, but this is
>> probably safe to skip, because those two parts are unlikely to be
>> readable anyway, and the only part we are effectively omitting (the
>> first subpart) is guaranteed to be empty anyway, so its removal can be
>> reversed if you want to do so. I've left FIXMEs in the code so that
>> anyone excited about adding these additional checks can see where to
>> put them in.
>>
>> I'll use this functionality in the next two patches.
>
> If there is going to be more versions, then the above line could be removed...
>
> (as committed changes are not "patches" ...)
I concur with (and appreciate) your terminological pedantry. the
revision on my gitlab branch has adopted your suggestions, but i don't
want to burden the list with another revision right now. hopefully this
change to the commit message won't block adoption -- anyone merging the
series should feel free to adjust the commit message as Tomi recommends.
--dkg
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
next prev parent reply other threads:[~2019-09-16 0:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 3:27 v4 of repairing Mixed-up mangled MIME messages Daniel Kahn Gillmor
2019-09-09 3:27 ` [PATCH v4 1/4] test: add test for "Mixed-Up Mime" message mangling Daniel Kahn Gillmor
2019-09-09 3:27 ` [PATCH v4 2/4] util/repair: identify and repair "Mixed Up" mangled messages Daniel Kahn Gillmor
2019-09-14 1:58 ` David Bremner
2019-09-15 7:37 ` Daniel Kahn Gillmor
2019-09-15 7:38 ` [PATCH v5 " Daniel Kahn Gillmor
2019-09-15 20:26 ` Tomi Ollila
2019-09-15 23:09 ` Daniel Kahn Gillmor [this message]
2019-09-09 3:27 ` [PATCH v4 3/4] index: repair "Mixed Up" messages before indexing Daniel Kahn Gillmor
2019-09-09 3:27 ` [PATCH v4 4/4] cli/{show, reply}: use repaired form of "Mixed Up" mangled messages Daniel Kahn Gillmor
[not found] ` <87zhj5xcet.fsf@tethera.net>
2019-09-16 10:49 ` David Bremner
2019-09-17 5:59 ` Daniel Kahn Gillmor
2019-09-17 23:36 ` David Bremner
2019-09-14 7:29 ` v4 of repairing Mixed-up mangled MIME messages Jameson Graef Rollins
2019-09-14 11:30 ` David Bremner
2019-09-14 16:08 ` Jameson Graef Rollins
2019-09-14 17:33 ` David Bremner
2019-09-15 3:05 ` Daniel Kahn Gillmor
2019-09-14 17:54 ` Daniel Kahn Gillmor
2019-09-14 23:58 ` Jameson Graef Rollins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7b517il.fsf@fifthhorseman.net \
--to=dkg@fifthhorseman.net \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).