From: David Bremner <david@tethera.net>
To: Floris Bruynooghe <flub@devork.be>, notmuch@notmuchmail.org
Subject: Re: [PATCH] Support aborting the atomic context
Date: Mon, 15 Jun 2020 07:35:00 -0300 [thread overview]
Message-ID: <87a714y5uz.fsf@tethera.net> (raw)
In-Reply-To: <20200614152319.57064-1-flub@devork.be>
Floris Bruynooghe <flub@devork.be> writes:
> This is an implementation of what was suggested in
> id:87v9k96xtl.fsf@powell.devork.be It closes the database as that is
> the only safe way to do this afaik.
>
> Currently when the database is closed there are still a bunch of
> operations which can result in segfaults. Yet the API also promises
> that some operations are still valid, basically those which only
> access already previously retrieved information. It would be nice to
> find a good solution for this in the python bindings, but I don't yet
> know what this would be.
There is a Xapian method WritableDatabase::cancel_transaction(), but it
is not currently exposed by notmuch. I think it could be added, but
getting the testing working right is not something I want to tackle at
this point in the release cycle. I guess this should be upwardly
compatible, as all code correct for your current implementation should
still work if we replace notmuch_database_close with
notmuch_cancel_atomic. Thoughts?
d
next prev parent reply other threads:[~2020-06-15 10:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-14 15:23 [PATCH] Support aborting the atomic context Floris Bruynooghe
2020-06-14 15:23 ` Floris Bruynooghe
2020-06-16 11:22 ` David Bremner
2020-06-15 10:35 ` David Bremner [this message]
2020-06-15 19:55 ` Floris Bruynooghe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a714y5uz.fsf@tethera.net \
--to=david@tethera.net \
--cc=flub@devork.be \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).