From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 0EsKNIwZ6F5dJgAA0tVLHw (envelope-from ) for ; Tue, 16 Jun 2020 00:59:56 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 4PjiL4wZ6F7JUAAA1q6Kng (envelope-from ) for ; Tue, 16 Jun 2020 00:59:56 +0000 Received: from arlo.cworth.org (arlo.cworth.org [50.126.95.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D824194036C for ; Tue, 16 Jun 2020 00:59:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id A75E46DE025A; Mon, 15 Jun 2020 17:59:50 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RjsGKdxskSLR; Mon, 15 Jun 2020 17:59:50 -0700 (PDT) Received: from arlo.cworth.org (localhost [IPv6:::1]) by arlo.cworth.org (Postfix) with ESMTP id 4C9146DE09B0; Mon, 15 Jun 2020 17:59:48 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id D581F6DE09B0 for ; Mon, 15 Jun 2020 17:59:46 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ohlLt7D8QuT6 for ; Mon, 15 Jun 2020 17:59:44 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id 1B6C66DE025A for ; Mon, 15 Jun 2020 17:59:43 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.92) (envelope-from ) id 1jkzwx-0006NB-RV; Mon, 15 Jun 2020 20:59:39 -0400 Received: (nullmailer pid 1905032 invoked by uid 1000); Tue, 16 Jun 2020 00:59:38 -0000 From: David Bremner To: Floris Bruynooghe , notmuch@notmuchmail.org Subject: Re: python: config API In-Reply-To: <20200615215553.220529-1-flub@devork.be> References: <20200615215553.220529-1-flub@devork.be> Date: Mon, 15 Jun 2020 21:59:38 -0300 Message-ID: <87a713966d.fsf@zancas> MIME-Version: 1.0 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: notmuch-bounces@notmuchmail.org Sender: "notmuch" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 50.126.95.6 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Spam-Score: -0.51 X-TUID: 7F0fMma+rByS Floris Bruynooghe writes: > This is a followup on the patch from Anton Khirnov adding config > API support to the python bindings. > > I can not help myself but point out that I did not spot the bug > until not only I had written tests, but until I looked at the > test coverage to see what was not yet executed and added more > tests. Tests and test coverage is good! > I've merged the revised series to release and master.