From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id yK2+EbShqF/mcgAA0tVLHw (envelope-from ) for ; Mon, 09 Nov 2020 01:56:04 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id EP+IDbShqF+QSwAAbx9fmQ (envelope-from ) for ; Mon, 09 Nov 2020 01:56:04 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AC54E9402C2 for ; Mon, 9 Nov 2020 01:56:02 +0000 (UTC) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id C7F83270EF; Sun, 8 Nov 2020 20:55:56 -0500 (EST) X-Greylist: delayed 474 seconds by postgrey-1.36 at nmbug; Sun, 08 Nov 2020 20:55:53 EST Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mail.notmuchmail.org (Postfix) with ESMTPS id B65A91FFB6 for ; Sun, 8 Nov 2020 20:55:53 -0500 (EST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 0E2C05C025D for ; Sun, 8 Nov 2020 20:47:59 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sun, 08 Nov 2020 20:47:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=resent-to:resent-from:resent-date:resent-message-id:from:to :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=fm1; bh=yw1P1sTE2p8K6D6l9waeFR+c5bWDozDDd4HEGwG WnAQ=; b=s+DYLnMzSy8OyjIO2trg+rOsr74YfPMwP68ZmvQTVmf3kZoWC95gqW3 dWgt4Q3u4P40uDkmE8tkqDpjb5UnbTlIcf2TqEvMuSMX1mNcIlzTPOTxxW6tRRet D8mqaPXAFsr/c3wECOqbE7CAxlCIzlgL4mucB0MibKeRTh8l0QEkZleh7EyDR+h0 QOy8PuBI3lzy3YZqMAm0PL52uWnT3hBh75erlLyIs5fy9Xk8y1TiBPBJsU0THtnl hy/tPaU9RBy0YYOL8PY76iIbsUyw7I/LH6vv9ffpQ4g14kI0qfmSDXP2jsEzG5JZ anD12XpGanLdeifJOOUGsX2VIMB3eeA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:resent-date:resent-from :resent-message-id:resent-to:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=yw1P1sTE2p8K6D6l9 waeFR+c5bWDozDDd4HEGwGWnAQ=; b=BVvWjlvu2+OtLehq83hdYTbWczW959xV+ VxSxR5ZxaFuncOikKOpphr6lTvICCnI2s9wdfge0yh+EBtGLKwfZ19sgxLup6i7d 7Jr2ydMH7NM+XL48ik8+L/yeoIaEfpMYumZjza9DtQSIHbEC0Yx49O6djcMuj7lT gEUGLymNeo0c137llfN/dnhV0uzkVqIj9gBNKOhs2nI2QjpIFu1kWPudWZVHKEjz AdvO0qWECx+RPzgQ4ICjT5cNNtfvQY7tpMxpo1eQDSu0Qm0zzkaWRaaUtfcUVkm9 18+1AJ9etibUFirRWwDn8vxqF9oTCOvkmN0gohHpr9Hfd/xI8ZMLA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddugedgfeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhffkfggtgesthdtredttddttdenucfhrhhomhepufgvrghnucgh hhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqeenuc ggtffrrghtthgvrhhnpeegtddvheegfffhffdvfeefhffgjefflefhteevffffkeetgfdt jedtiedvtdevheenucevlhhushhtvghrufhiiigvpedunecurfgrrhgrmhepmhgrihhlfh hrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Resent-To: notmuch@notmuchmail.org Resent-From: spwhitton@spwhitton.name Resent-Date: Sun, 08 Nov 2020 18:47:57 -0700 Resent-Message-ID: <877dqv1esy.fsf@melete.silentflame.com> From: Sean Whitton To: Jonas Bernoulli Subject: Re: [PATCH] Revert "emacs: notmuch-search: avoid wiping out buffer-local variables" In-Reply-To: <20201108174929.1227-1-jonas@bernoul.li> References: <20201108174929.1227-1-jonas@bernoul.li> Date: Sun, 08 Nov 2020 18:47:50 -0700 Message-ID: <87a6vr1et5.fsf@melete.silentflame.com> MIME-Version: 1.0 Message-ID-Hash: 633BEPRBB3X5DW5FLIPO4CQVX3DGUFF3 X-Message-ID-Hash: 633BEPRBB3X5DW5FLIPO4CQVX3DGUFF3 X-MailFrom: spwhitton@spwhitton.name X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=fail (body hash did not verify) header.d=spwhitton.name header.s=fm1 header.b=s+DYLnMz; dkim=fail (body hash did not verify) header.d=messagingengine.com header.s=fm1 header.b=BVvWjlvu; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Spam-Score: -0.01 X-TUID: q19YvfOznxK+ Hello, On Sun 08 Nov 2020 at 06:49PM +01, Jonas Bernoulli wrote: > This reverts commit f9fbd1ee3bfd679175d88af403752d87a730349f. > > Emacs provides a mechanism for avoiding wiping out buffer-local > variables: marking them as "permanent local", which essentially > means "don't wip out the local value when enabling major-mode". > > (put 'the-variable 'permanent-local t) > > See (info "(elisp)Creating Buffer-Local"). > > Whether refreshing the buffer contents should involve re-enable the > mode is a different question, which should not be decided based on > the fact that we want keep the value of some random variable, not > least because some other (e.g. cache) variables are likely expected > to be wiped. Nice, thank you for the info. I've tested that my usecase works after reverting the patch so I support reverting it. Reviewed-by: Sean Whitton -- Sean Whitton