From: Sean Whitton <spwhitton@spwhitton.name>
To: Jonas Bernoulli <jonas@bernoul.li>
Subject: Re: [PATCH] Revert "emacs: notmuch-search: avoid wiping out buffer-local variables"
Date: Sun, 08 Nov 2020 18:47:50 -0700
Message-ID: <87a6vr1et5.fsf@melete.silentflame.com> (raw)
In-Reply-To: <20201108174929.1227-1-jonas@bernoul.li>
Hello,
On Sun 08 Nov 2020 at 06:49PM +01, Jonas Bernoulli wrote:
> This reverts commit f9fbd1ee3bfd679175d88af403752d87a730349f.
>
> Emacs provides a mechanism for avoiding wiping out buffer-local
> variables: marking them as "permanent local", which essentially
> means "don't wip out the local value when enabling major-mode".
>
> (put 'the-variable 'permanent-local t)
>
> See (info "(elisp)Creating Buffer-Local").
>
> Whether refreshing the buffer contents should involve re-enable the
> mode is a different question, which should not be decided based on
> the fact that we want keep the value of some random variable, not
> least because some other (e.g. cache) variables are likely expected
> to be wiped.
Nice, thank you for the info. I've tested that my usecase works after
reverting the patch so I support reverting it.
Reviewed-by: Sean Whitton <spwhitton@spwhitton.name>
--
Sean Whitton
next prev parent reply other threads:[~2020-11-09 1:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-08 17:49 Jonas Bernoulli
2020-11-09 1:47 ` Sean Whitton [this message]
2020-12-25 18:34 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6vr1et5.fsf@melete.silentflame.com \
--to=spwhitton@spwhitton.name \
--cc=jonas@bernoul.li \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
unofficial mirror of notmuch@notmuchmail.org
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://yhetil.org/notmuch/0 notmuch/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 notmuch notmuch/ https://yhetil.org/notmuch \
notmuch@notmuchmail.org
public-inbox-index notmuch
Example config snippet for mirrors.
Newsgroups are available over NNTP:
nntp://news.yhetil.org/yhetil.mail.notmuch.general
nntp://news.gmane.io/gmane.mail.notmuch.general
AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git