From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id G149JSLYVWDLFwAA0tVLHw (envelope-from ) for ; Sat, 20 Mar 2021 11:10:26 +0000 Received: from aspmx2.migadu.com ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id cK2eICLYVWB/FwAA1q6Kng (envelope-from ) for ; Sat, 20 Mar 2021 11:10:26 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx2.migadu.com (Postfix) with ESMTPS id A76A027533 for ; Sat, 20 Mar 2021 12:10:25 +0100 (CET) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 0C81A1FE96; Sat, 20 Mar 2021 07:10:20 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id 51D9E1FBA6 for ; Sat, 20 Mar 2021 07:10:15 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id 2BFA05FA96; Sat, 20 Mar 2021 07:10:13 -0400 (EDT) Received: (nullmailer pid 2198658 invoked by uid 1000); Sat, 20 Mar 2021 11:10:11 -0000 From: David Bremner To: notmuch@notmuchmail.org Subject: Re: v4 flexible path location In-Reply-To: <20210314140217.183425-1-david@tethera.net> References: <20210314140217.183425-1-david@tethera.net> Date: Sat, 20 Mar 2021 08:10:11 -0300 Message-ID: <87a6qy13os.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: 4BTTS4RJHXAGBTSUBHBPWU36LW7QUVXV X-Message-ID-Hash: 4BTTS4RJHXAGBTSUBHBPWU36LW7QUVXV X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1616238626; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=W0hHEGV3ZLV3AUSG04y1D+nZXlaf3PMt2XH3uFN5x3E=; b=bnHwEblrC9nAO03g9zFDJCqUSGhrkGCrrpVliMM30rWuqoQYlElRPyjzef7Udmn/auNk37 BFr80EO58jQBIRPNtfQFGqjbVxyrnZcloSumPpqWWs0IhWc9b3qhXMwIe8xecI52GAZQta m7/ThMeKx/Tc78EUhHJGh8+FLQLZH7TXHxdIhMOgkFWjcLs5GW+OozINgvZWR0GFxSrQzg lcTi82Lovlmf2wIKsHMDFNO3A7PoF9q3hwlR+1BdtUNFxlKFfSTPURmXv2EAl7Cp11OwHU G/EUx0mB/fRIeBk4zZT/XfaXetkwVtIsFQ3ZBFAEdx1KQYVwPnS4XXnRHN/jTg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1616238626; a=rsa-sha256; cv=none; b=UBy/QEVHzv8UWOcdzaVQ21BiLacI2ytaeG3UHn4mDQ9BpizZCs8IZf0QZEwMoKi+yfUfm+ 9mYtP/AAEsckThHiYo66J8VejhQ9TEXRrn0B6mTUKxVj5Uas2LjDO7Gfymnsxz3/uFl7Jx 8M19lNHz2xitGiKoqQChHqPPcgypVaY8f3T4ISmioUgRnALhIxq+jHiMzqnrxi1RzVJrVb NYPI/9yHr2VJck9hOq0r4VevORiQPZWNKDXD5cRvsholEKt4kJETFfSLsiRjNtIenG+wXC dofAcfG8BVgVCVeHUB4IvjUTfoOOAHL1qrQOCvyaQEhZRt073mhtNlLIFdA+Yw== ARC-Authentication-Results: i=1; aspmx2.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx2.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -1.94 Authentication-Results: aspmx2.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx2.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: A76A027533 X-Spam-Score: -1.94 X-Migadu-Scanner: scn0.migadu.com X-TUID: SUuUvSuwEKEP David Bremner writes: > Since v3 [1] > > - rebase against the uncrustified version (unfortunately this makes an > interdiff too noisy to be helpful). > - improve (?) the documentation of database.mail_root in notmuch-config(1). > - tweak commit messages > - move the call to _init_libs from [10/22] to [9/22] > > I'm going to mark this version as ready to apply, so object now, or > grumble later. Rebasing this on top of the hook fix, I noticed the following diff --git a/lib/open.cc b/lib/open.cc index c9390359..8f572b0b 100644 --- a/lib/open.cc +++ b/lib/open.cc @@ -508,7 +508,7 @@ notmuch_database_open_with_config (const char *database_path, _set_database_path (notmuch, database_path); - status = _notmuch_choose_xapian_path (local, database_path, + status = _notmuch_choose_xapian_path (notmuch, database_path, ¬much->xapian_path, &message); if (status) goto DONE; Like all good memory bugs, this was mysteriously undetected until reopen was called multiple times in the hook fix. This is now fixed in my git repo. I'll hold off posting another series for now. d