From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Subject: Re: v4 flexible path location
Date: Sat, 20 Mar 2021 08:10:11 -0300 [thread overview]
Message-ID: <87a6qy13os.fsf@tethera.net> (raw)
In-Reply-To: <20210314140217.183425-1-david@tethera.net>
David Bremner <david@tethera.net> writes:
> Since v3 [1]
>
> - rebase against the uncrustified version (unfortunately this makes an
> interdiff too noisy to be helpful).
> - improve (?) the documentation of database.mail_root in notmuch-config(1).
> - tweak commit messages
> - move the call to _init_libs from [10/22] to [9/22]
>
> I'm going to mark this version as ready to apply, so object now, or
> grumble later.
Rebasing this on top of the hook fix, I noticed the following
diff --git a/lib/open.cc b/lib/open.cc
index c9390359..8f572b0b 100644
--- a/lib/open.cc
+++ b/lib/open.cc
@@ -508,7 +508,7 @@ notmuch_database_open_with_config (const char *database_path,
_set_database_path (notmuch, database_path);
- status = _notmuch_choose_xapian_path (local, database_path,
+ status = _notmuch_choose_xapian_path (notmuch, database_path,
¬much->xapian_path, &message);
if (status)
goto DONE;
Like all good memory bugs, this was mysteriously undetected until reopen
was called multiple times in the hook fix.
This is now fixed in my git repo. I'll hold off posting another series
for now.
d
next prev parent reply other threads:[~2021-03-20 11:10 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-14 14:01 v4 flexible path location David Bremner
2021-03-14 14:01 ` [PATCH 01/22] test/setup: add check for config exists, but no database David Bremner
2021-03-14 14:01 ` [PATCH 02/22] lib: publish API for notmuch_database_reopen David Bremner
2021-03-14 14:01 ` [PATCH 03/22] lib: save path of xapian database in notmuch struct David Bremner
2021-03-14 14:01 ` [PATCH 04/22] lib: support reopening databases for write access David Bremner
2021-03-18 11:11 ` David Bremner
2021-03-14 14:02 ` [PATCH 05/22] CLI/show: complete conversion to new configuration framework David Bremner
2021-03-14 14:02 ` [PATCH 06/22] lib/open: support NOTMUCH_DATABASE environment variable David Bremner
2021-03-14 14:02 ` [PATCH 07/22] lib/open: allocate notmuch_t struct early David Bremner
2021-03-14 14:02 ` [PATCH 08/22] lib: remove "path" from notmuch struct David Bremner
2021-03-14 14:02 ` [PATCH 09/22] lib/open: factor out library initialization David Bremner
2021-03-14 14:02 ` [PATCH 10/22] lib/open: reuse directory checks from n_d_c_with_config David Bremner
2021-03-14 14:02 ` [PATCH 11/22] lib/open: factor out the second half of n_d_open_with_config David Bremner
2021-03-14 14:02 ` [PATCH 12/22] lib/open: use _finish_open in n_d_create_with_config David Bremner
2021-03-14 14:02 ` [PATCH 13/22] lib/open: Use check for existing database by trial opening David Bremner
2021-03-14 14:02 ` [PATCH 14/22] lib: support splitting mail from database location David Bremner
2021-03-14 14:02 ` [PATCH 15/22] lib/open: check for split configuration when creating database David Bremner
2021-03-14 14:02 ` [PATCH 16/22] CLI/new: support split database and mail location David Bremner
2021-03-14 14:02 ` [PATCH 17/22] lib/open: support XDG_DATA_HOME as a fallback database location David Bremner
2021-03-14 14:02 ` [PATCH 18/22] CLI/insert: support split database and mail root David Bremner
2021-03-14 14:02 ` [PATCH 19/22] lib/compact: enable split config David Bremner
2021-03-14 14:02 ` [PATCH 20/22] lib/open: fix hook directory calculation in split configuration David Bremner
2021-03-14 14:02 ` [PATCH 21/22] lib/config: add configuration variable for backup directory David Bremner
2021-03-14 14:02 ` [PATCH 22/22] CLI/new: use " David Bremner
2021-03-20 11:10 ` David Bremner [this message]
2021-03-24 11:08 ` v4 flexible path location David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6qy13os.fsf@tethera.net \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).