From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gNdxHR+y9GC0cgAAgWs5BA (envelope-from ) for ; Mon, 19 Jul 2021 00:58:39 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id GPfSGB+y9GDzOgAAB5/wlQ (envelope-from ) for ; Sun, 18 Jul 2021 22:58:39 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 34C712DCB7 for ; Mon, 19 Jul 2021 00:58:39 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id ED7F9290CE; Sun, 18 Jul 2021 18:58:35 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id 6E738290AE for ; Sun, 18 Jul 2021 18:58:34 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id 571AB5FD21; Sun, 18 Jul 2021 18:58:34 -0400 (EDT) Received: (nullmailer pid 4229 invoked by uid 1000); Sun, 18 Jul 2021 22:58:33 -0000 From: David Bremner To: Felipe Contreras , notmuch@notmuchmail.org Subject: Re: [PATCH 1/2] ruby: create an actual wrapper struct In-Reply-To: <20210517193915.1220114-2-felipe.contreras@gmail.com> References: <20210517193915.1220114-1-felipe.contreras@gmail.com> <20210517193915.1220114-2-felipe.contreras@gmail.com> Date: Sun, 18 Jul 2021 19:58:33 -0300 Message-ID: <87a6mj6xgm.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: FZSNG2RED2E4FOOBSSITAMQS5V6U2QEM X-Message-ID-Hash: FZSNG2RED2E4FOOBSSITAMQS5V6U2QEM X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Tomi Ollila X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1626649119; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=kyrgpcFU+S+xk/K2FzIafbnLsqkGAqHn+3pmMx+fpVA=; b=oy0VPqJUd+VObtmYjNPnXcY49ZZvq6U9L4egvJ7QCBUMmuRUO/FDEjeRbMVPF+wpmTlmwV 7ofOqe9Dz2fK6PgI8coiYPClgEo822091MEV90mU3uMDqQG7FsGXAqfY9Vd+o74iH4W5s2 2oD5G8GyWh3ZsY60psvgzZQyWap86MTZcaRHc9GN2txqXZdL/4loOa7NkblQlDAaIvi4wC rZ4qUe04l7byRWpgNO8MPyicJUz1tNUXiVuzOtlqPz4Rf7pdHSaNGkXLQdgWnklUpdlOHS QbTDTAI+YBVg75TkGP/mlSNhmijrD+yqE3h4c+2BeJbmvf9bwo7eosW9kLtH2g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1626649119; a=rsa-sha256; cv=none; b=sxTlmsq7VjQ1MyUMnLkiK0LuFBuAHAKeuzXcgRPt4GwEJBeLqgJtu3yEwAkIrjZa7Jv3HM MSStmhNPenH4VbpMUp5tFMIRNAp+dU/bCeZ6cyTShTcMGI7RwibHg6HYEsjOZW+4Q8bOpo pTZWEqaP94Le+WqFdj8R9FEvTAOlBo5sKOUu/pmAgqq4LHGtC92pUYcq3JAHmK/n8Ic219 1UHYjv7UupZ8xizgYn/Xd3vLnxgFzy/nO+4D+0rmnrLkySI/5Goplt8EcE1Zly0neBaY1n R+tBh5iBp+KoXUFecVu4evh0SApPBD8vxSnb5y/jHTe4kFW+qx3qX5q5ZhbqaQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.08 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 34C712DCB7 X-Spam-Score: -2.08 X-Migadu-Scanner: scn0.migadu.com X-TUID: XaSPGPMT7AGy Felipe Contreras writes: > Currently Ruby data points directly to a notmuch object (e.g. > notmuch_database_t), since we don't need any extra data that is fine. > > However, in the next commit we will need extra data, therefore we create > a new struct notmuch_rb_object_t wrapper which contains nothing but a > pointer to the current pointer (e.g. notmuch_database_t). Series applied to master. I had a second look at the API and I'm reasonably confident that all of the the things you call define_type for are allocated by talloc. d