From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 8OnTICZe9WA/FAAAgWs5BA (envelope-from ) for ; Mon, 19 Jul 2021 13:12:38 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 6O0rHCZe9WDbegAA1q6Kng (envelope-from ) for ; Mon, 19 Jul 2021 11:12:38 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8177AFF1E for ; Mon, 19 Jul 2021 13:12:37 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 943CE290A8; Mon, 19 Jul 2021 07:12:33 -0400 (EDT) Received: from mail.hostpark.net (mail.hostpark.net [212.243.197.30]) by mail.notmuchmail.org (Postfix) with ESMTPS id 20AC5290A8 for ; Mon, 19 Jul 2021 07:12:31 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id F140C16454; Mon, 19 Jul 2021 13:12:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-type:content-type:mime-version:message-id:date:date :references:in-reply-to:subject:subject:from:from:received :received; s=sel2011a; t=1626693147; bh=VT2dCBy5CBACG6NB+Q7tbvhU zLJwyhqAeg1LuBxMnwU=; b=ndu778DqOO+Vum3t8Nc1fbPTmL1YTfQAxr3LRzAq eqqdXOS3kdIy17OIAHv/sztnrbRmra6tVx9vRoNWI/L+mpmKA8qU8exm7a4n4n++ /HEiADGbKah93P8+376NCnNUrBO2Dm7ZELAFFOUypEfCYkbIeckEqgftMYhzGx5M 5gQ= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id 7l_MwIeSJ0mK; Mon, 19 Jul 2021 13:12:27 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id A196B163CB; Mon, 19 Jul 2021 13:12:27 +0200 (CEST) From: Jonas Bernoulli To: David Bremner , Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: notmuch-tree: mark the initial message at point as read In-Reply-To: <87tumcimhy.fsf@tethera.net> References: <20210216000138.19625-1-jonas@bernoul.li> <87im6euzwh.fsf@bernoul.li> <87ft1iuzeh.fsf@bernoul.li> <87tumcimhy.fsf@tethera.net> Date: Mon, 19 Jul 2021 13:12:27 +0200 Message-ID: <87a6mi5zhg.fsf@bernoul.li> MIME-Version: 1.0 Message-ID-Hash: ZZU4VYMTSEUIE2J46IH2KG6LZTMT3GHU X-Message-ID-Hash: ZZU4VYMTSEUIE2J46IH2KG6LZTMT3GHU X-MailFrom: jonas@bernoul.li X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1626693158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=Sx6QI1WQD63HzhjqZmZZetllQJLK/Qc3KZAb/+RJ2Dg=; b=Y7sa5EP7F26BtMGA/CJP7hp2AuzSjTUuwlDa+zLUa9P3+fNWRmrdKTOsV1CzF3GLJuD3a8 K6Elts3KTeaWmKABrm2UWlFaYjteRLTf4nSK/ELNW4D2CHFrgsFDZsqPABe/mAnsNddYy9 7x5fnMXmAZsHPdFTY3QfjRxnNRCOjFEhEEfrV0RSfluux5FgXl3RI0Uay3/ToGspXmj/u5 NBDrRpJYVbEpZxn2UklrcKTJJDrdalv6pC+MlJG9YIzFSd9PxOxDYNr2HwGAPrOVG3vJwb VxliVoYKpNqZ5MlT+JZSQ/H1auV7C1A2byuhwxtIK0UrDCo6iR1KPf1ze+rqHg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1626693158; a=rsa-sha256; cv=none; b=K+QjlvqyK5/NHbejLlm8iOv4xbOiMstozg+FHt8jG0RwJfT5HTCHj4t3yOxJ4qYJd8s3hP T0I5asNeEa65CX3TQJbIddNutueTxE7YfZX+MKQ2TPjWT3GUxxRnvrnRjt6SNVKaNMLfTW qSH6+83EsTY0Y3PHyEauAK6M4tAWRNOCZLkZlM4Er2wGX61bQOErM+PxBGU5EI/yt/3JVy f/iJaRz/sOXjgy7QIRNO1Z6nB1TNIdVvtUjiInYCMESW7wnuBfpV2O+/taDBnlJKi46iUu 99vZ8enIqC/yif20XHmj51/cZ2dMe9FDIWbztuZFZEKCYDFtgUmxLjo7ZIqoow== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=bernoul.li header.s=sel2011a header.b=ndu778Dq; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -1.08 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=bernoul.li header.s=sel2011a header.b=ndu778Dq; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 8177AFF1E X-Spam-Score: -1.08 X-Migadu-Scanner: scn1.migadu.com X-TUID: VhgdfpAqlOJ4 David Bremner writes: > Jonas Bernoulli writes: > >> Hm, when no tree buffer is involved, then `notmuch-show-command-hook' >> probably is required. Anyway, there seems to be some undead code and >> rethinking all this would be a good idea. > > I'm not sure I followed the discussion, but I'm marking > id:20210216000138.19625-1-jonas@bernoul.li as "notmuch::moreinfo", > meaning we're expecting another version from Jonas. If that's wrong, > please let me know. > > d Please merge the proposed fix; IMO it is sound. My follow-up, the reply to Tomi, seems quite confused though. But just because we are uncertain whether there is further room for improvement, that shouldn't keep us from fixing the bug. Maybe in the future we can improve upon this fix but I probably won't investigate any time soon. Jonas