From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id cEv7L5bnZmESQgEAgWs5BA (envelope-from ) for ; Wed, 13 Oct 2021 16:05:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id kM6iK5bnZmEjUAAA1q6Kng (envelope-from ) for ; Wed, 13 Oct 2021 14:05:10 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 653BCD76E for ; Wed, 13 Oct 2021 16:05:10 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 4CFA12C1AA; Wed, 13 Oct 2021 10:05:08 -0400 (EDT) Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by mail.notmuchmail.org (Postfix) with ESMTPS id A8D572C1A8 for ; Wed, 13 Oct 2021 10:05:06 -0400 (EDT) Received: by mail-lf1-x130.google.com with SMTP id r19so12198252lfe.10 for ; Wed, 13 Oct 2021 07:05:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nikula-org.20210112.gappssmtp.com; s=20210112; h=from:to:subject:in-reply-to:references:date:message-id:mime-version; bh=Zsk8nGVn3l8+7F9bdK3t61ku/Sya40wD1TtKNtmKe1Y=; b=PrLU78CIISim6HdI7bTP+OPEODMyOqTkWsoyJXnwArH1y4pWP6D2azdefr1lC2tBg5 K53S/HJvvV1xAvzoFfs3oIlU9mLf5g8rZKPsOlzMA5S5FKSrg6RisCo8BYMXsRLiA+vC 3QUkr+7+z42UAYLrKm6NYMhjh0de0x/D1B7cfloQIP9kaITeAYDt2TE0F//QSg1vRrsr gQsoO7lH+IwJgQ2tQhTV20dKAjTPwP7HH7xJFB6m7+xD/UKcztkfQ2dBr8TWej0PtJpl pUbsYteZ87WDsSIaxAmxEyee/1BRqwxF8aGsvbDLvbETSZ6/ewC0WNsb/xOAg8AkEmfc r4PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=Zsk8nGVn3l8+7F9bdK3t61ku/Sya40wD1TtKNtmKe1Y=; b=vCFkS8bqBQ6zMiBaGCdbKKGTKH0OwMxLI/Inw/ruR8iJI2OZ08e+ZTwptOLt7pQAhx phQ3YSgy/fs8x7XOasIRmcfhxwUc9aej7bI0kS1AP7E1auHlh27iv+xhyYLBxbVclPDd ZJTFhm0DgouZVF03os4FmMIvupm7CxlWWW8a8CZILoSuxOLvhDtoJ+HvFz2lUf6RfQTR zv6ONEdH7+0/4D8CCtTDmSQKbJBrkJsBu3Ed02xwu+qzFbTqCYlO8NJehqxIXi7wmjbR Y2fY8QW4gAb5el5GG8E9wIbmXe9fL3WxZCB0LT66Q6S9YfWLq94DrmPnUOzb5XBeM6P2 Hc6w== X-Gm-Message-State: AOAM530C/i4F1bMts4t8nQF8qwTlYALyL/MFXiQXZkJOj1p3bkr789VQ p9hejNGwaLtX9gI5kpXAgZoQRvSEdN6JezHEGsA= X-Google-Smtp-Source: ABdhPJwUO6H1tcnD/hNitlVaMmrEfBnVefGFf3xfw+CwHeB/2lNDH3FMp92eqnnwthpgKDJyzBQEOA== X-Received: by 2002:a05:651c:290:: with SMTP id b16mr37730726ljo.178.1634133894550; Wed, 13 Oct 2021 07:04:54 -0700 (PDT) Received: from localhost (87-95-50-104.bb.dnainternet.fi. [87.95.50.104]) by smtp.gmail.com with ESMTPSA id d26sm117421lfb.297.2021.10.13.07.04.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Oct 2021 07:04:54 -0700 (PDT) From: Jani Nikula To: David Bremner , notmuch@notmuchmail.org Subject: Re: [RFC 3/5] lib: remove commented out NOTMUCH_DEPRECATED() In-Reply-To: <87v921kqp2.fsf@tethera.net> References: <20211012185127.198348-1-jani@nikula.org> <20211012185127.198348-4-jani@nikula.org> <87v921kqp2.fsf@tethera.net> Date: Wed, 13 Oct 2021 17:04:52 +0300 Message-ID: <87a6jd10mz.fsf@nikula.org> MIME-Version: 1.0 Message-ID-Hash: 7NQEMD27BE74UNTJXKUUAHML6A3PAV7J X-Message-ID-Hash: 7NQEMD27BE74UNTJXKUUAHML6A3PAV7J X-MailFrom: jani@nikula.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634133910; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=XkvS1/aIuH/PSEdQAHuvZyUUt0w92dEkrFjCNUQ/4f0=; b=hPHGws9cKwq8XXrpG0i/BSEyUwO/XeFKsqRQTARWwTcVwieHz7AaMR0QV/C4tWETAATKEy y5k02NmRmuDlMG6jYuhIdW+HbrL53DtxnyDl+pZbaOV3eyrmZxwIgiSIf9JqUqzwIv0arF kDdk0hkwv9/ZFKrF1Nu5Lm3OX9Yqw5vlzkfH7W2b0U+Hd0aC1KyJDTwAGhXCgNlqcd82H/ ji/1sAH5pVhNeMLZXlkjZNXmLs0nbPD1M6Y6FndfEzFzvitTlD8qHASkAlAXX3BiUMguD8 sYxUtPJ0h/QUBphJCwLsUpS3Kt5ejQUQQxjn7IW9LTUPI5iR+wYFInvIC44YvA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634133910; a=rsa-sha256; cv=none; b=amKUJtpq/Cdj2qB9/t5kQKffaTYKQoZx6IDjyPE6j/bKQwcQRbm5eobRua3MRo9P8D9ihG OUui1mh0GJRPCrAjS3RmOFHVAXGTCXG2rP/idcDH+DF2nIlzT/7PCr1BwIrfTY0QtU+8Hv osiHMssxCQ3WlbWftZF90q8OypUs3FmEDt5SwnCkGJzVYVwY36ese3Jbn33yM/JqG530Ix LsMoTedbadZWwhlwtmAzItpekGtuP3kqH12CUNac9FFyMXgNkBm0FO3OEbzP2fdcEm3na/ HJWECw995McMDmhETHrCBGZxHZKPOr6n0o1S+d3SYASPYVneifJcpW0fpeZ/Cg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=nikula-org.20210112.gappssmtp.com header.s=20210112 header.b=PrLU78CI; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -1.18 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=nikula-org.20210112.gappssmtp.com header.s=20210112 header.b=PrLU78CI; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 653BCD76E X-Spam-Score: -1.18 X-Migadu-Scanner: scn1.migadu.com X-TUID: oCpglU1wA9Fi On Wed, 13 Oct 2021, David Bremner wrote: > Jani Nikula writes: > >> Having comments between the documentation comment and the object being >> documented throws Hawkmoth off. Remove the placeholder >> NOTMUCH_DEPRECATED() comments. >> >> --- >> >> They were added in commit e5f3c3ed5024 ("lib: add stub for >> notmuch_database_open_with_config"); maybe the comment markers should >> be removed instead? > > Yes, those should be uncommented, I think. Thanks, sent separately. Though it does give deprecation warnings now. BR, Jani.