From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id MD8sD7zYgWFzbQAAgWs5BA (envelope-from ) for ; Wed, 03 Nov 2021 01:33:00 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id UMO+CrzYgWEyMQAAbx9fmQ (envelope-from ) for ; Wed, 03 Nov 2021 00:33:00 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C68C727DE7 for ; Wed, 3 Nov 2021 01:32:59 +0100 (CET) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 855121FDDB; Tue, 2 Nov 2021 20:32:52 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id A5CAC1FA8E for ; Tue, 2 Nov 2021 20:32:49 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id 39E545FC42; Tue, 2 Nov 2021 20:32:49 -0400 (EDT) Received: (nullmailer pid 2509904 invoked by uid 1000); Wed, 03 Nov 2021 00:32:48 -0000 From: David Bremner To: Floris Bruynooghe Subject: Re: [PATCH 4/4] python-cffi: switch to notmuch_database_{open,create}_with_config In-Reply-To: <87tugu9r4a.fsf@powell.devork.be> References: <20211030162235.1203886-1-david@tethera.net> <20211030162235.1203886-5-david@tethera.net> <87tugu9r4a.fsf@powell.devork.be> Date: Tue, 02 Nov 2021 21:32:48 -0300 Message-ID: <87a6imxemn.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: 6DDMMPVPCAYBHRB7JFYECVGPTMC4IEO6 X-Message-ID-Hash: 6DDMMPVPCAYBHRB7JFYECVGPTMC4IEO6 X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: notmuch@notmuchmail.org X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1635899580; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=wqoxC4aZcwWnq6WqG5dqdNAlYYkvJHUb7HMMX59B6sY=; b=PioJaTMzUBvjU1cXFrP1cOnOFG0B97S5ec4WR/6wWkdfdMLGlwj8ijK75gxjouZlwih8Yr 8zysDjgPlS2YesVgSalIFarQJKhj+XhAVhngrwjj/xETk0H3OdPkHplMVVQ4y2SvN1EdHO FIFtRc3Qw40uXwWKf+RoxKLhqBOsYrLX/Pbaq+R6CkXUGFKpo5F0TPjJOCpap45WlHAsaS rxSFvve9T9tFS/tR3XTQUiYc4+8F8hrro5Gg7prQhRlPfAmGBTCpw5hzu0Av4gAS74z/vR 1tmtnicd4MakhYzCXVaPYVFl0kv+/pU1vRUJCv8RX412U1uVLKNVwZqSbS4Hmw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1635899580; a=rsa-sha256; cv=none; b=Y5fLTPc3RU8yI+TyVuXjWFTbb2ZjcUAxSvU0t1IRoN2pvB/k69ogiHtISKRhDLPDBisb7d pW1FsFvW6PE2DlMpyxUMfSEBTgWRYYbICqys4ADML8g4C7RDonFytaTScEqyB87xhUfuLW 0+DaJqzoOy5XBGkIF4lgTTsUr5YdXY/TxtaMaR8MNEOl0RM7h7xz7/2tG8rGvrtH7qSkX9 DxmytctJYu/HSmHkL7oj5MNYD0yIa06SF3yGXj46HulmxhHdNLzlT98ekZF2meuTcDpzZd Tl2nWERd7dnKuOO5p5Pu0bVQG9ONSai4qxCBLYFebUhA55D5EDYhN4rFG47Rog== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.10 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: C68C727DE7 X-Spam-Score: -2.10 X-Migadu-Scanner: scn0.migadu.com X-TUID: hvpin4byGQdY Floris Bruynooghe writes: > On Sat 30 Oct 2021 at 13:22 -0300, David Bremner wrote: >> + >> + .. deprecated:: 0.35 >> + Use the ``cfg_path`` parameter instead. > > Do you mean the ``config`` parameter to :meth:`__init__` or > :meth:`__create__` here instead of ``cfg_path``? > Good catch, that is indeed what I meant. [rest of patch snipped] > LGTM I think. > > As an aside, what is the oldest python version we still want to support? > I'm wondering if we can get rid of this `if not hasattr(os, 'PathLike')` > construct which only exists because of python 3.5. I usually go by what is in Debian oldstable, which is 3.7.x at this point. But maybe Tomi wants to comment, he is usually expert at finding old distros to run notmuch on ;) d PS: I took the liberty of replying to the list, hope that's OK.