unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Floris Bruynooghe <flub@devork.be>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH 4/4] python-cffi: switch to notmuch_database_{open,create}_with_config
Date: Tue, 02 Nov 2021 21:32:48 -0300	[thread overview]
Message-ID: <87a6imxemn.fsf@tethera.net> (raw)
In-Reply-To: <87tugu9r4a.fsf@powell.devork.be>

Floris Bruynooghe <flub@devork.be> writes:

> On Sat 30 Oct 2021 at 13:22 -0300, David Bremner wrote:
>> +
>> +        .. deprecated:: 0.35
>> +           Use the ``cfg_path`` parameter instead.
>
> Do you mean the ``config`` parameter to :meth:`__init__` or
> :meth:`__create__` here instead of ``cfg_path``?
>

Good catch, that is indeed what I meant.


[rest of patch snipped]

> LGTM I think.
>
> As an aside, what is the oldest python version we still want to support?
> I'm wondering if we can get rid of this `if not hasattr(os, 'PathLike')`
> construct which only exists because of python 3.5.

I usually go by what is in Debian oldstable, which is 3.7.x at this
point. But maybe Tomi wants to comment, he is usually expert at finding
old distros to run notmuch on ;)

d

PS: I took the liberty of replying to the list, hope that's OK.

  parent reply	other threads:[~2021-11-03  0:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-30 16:22 Use libnotmuch config / database search in python-cffi bindings David Bremner
2021-10-30 16:22 ` [PATCH 1/4] python-cffi: fix typos in docstring for Database.default_path David Bremner
2021-12-04 13:47   ` David Bremner
2021-10-30 16:22 ` [PATCH 2/4] test: add python-cffi bindings to path for test_python David Bremner
2021-10-30 16:22 ` [PATCH 3/4] test: add known broken tests for python bindings in split configs David Bremner
2021-10-30 16:22 ` [PATCH 4/4] python-cffi: switch to notmuch_database_{open,create}_with_config David Bremner
2021-10-31 19:46   ` Tomi Ollila
     [not found]   ` <87tugu9r4a.fsf@powell.devork.be>
2021-11-03  0:32     ` David Bremner [this message]
2021-11-03 21:49       ` Tomi Ollila
2021-11-05 18:17       ` Floris Bruynooghe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6imxemn.fsf@tethera.net \
    --to=david@tethera.net \
    --cc=flub@devork.be \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).