* [PATCH] emacs: use query name for tree saved-search buffer names
@ 2022-01-08 20:41 jao
2022-01-09 1:58 ` Jose Antonio Ortega Ruiz
2022-01-10 1:55 ` David Bremner
0 siblings, 2 replies; 5+ messages in thread
From: jao @ 2022-01-08 20:41 UTC (permalink / raw)
To: notmuch; +Cc: jao
This simply mimics what we already do for non-tree searches, and makes
up for nicer buffer names. Note that this patch only applies to
queries not coming from a search widget in the hello buffer.
Signed-off-by: jao <jao@gnu.org>
---
emacs/notmuch-hello.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
index fc007c4c..9f42a90b 100644
--- a/emacs/notmuch-hello.el
+++ b/emacs/notmuch-hello.el
@@ -487,7 +487,7 @@ diagonal."
(cl-case (widget-get widget :notmuch-search-type)
(tree
(notmuch-tree (widget-get widget :notmuch-search-terms)
- nil nil nil nil nil nil
+ nil nil (widget-value widget) nil nil nil
(widget-get widget :notmuch-search-oldest-first)))
(unthreaded
(notmuch-unthreaded (widget-get widget :notmuch-search-terms)))
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] emacs: use query name for tree saved-search buffer names
2022-01-08 20:41 [PATCH] emacs: use query name for tree saved-search buffer names jao
@ 2022-01-09 1:58 ` Jose Antonio Ortega Ruiz
2022-01-10 1:55 ` David Bremner
1 sibling, 0 replies; 5+ messages in thread
From: Jose Antonio Ortega Ruiz @ 2022-01-09 1:58 UTC (permalink / raw)
To: notmuch
On Sat, Jan 08 2022, jao wrote:
> This simply mimics what we already do for non-tree searches, and makes
> up for nicer buffer names. Note that this patch only applies to
> queries not coming from a search widget in the hello buffer.
sorry, i meant "queries *coming* from a search widget"
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] emacs: use query name for tree saved-search buffer names
2022-01-08 20:41 [PATCH] emacs: use query name for tree saved-search buffer names jao
2022-01-09 1:58 ` Jose Antonio Ortega Ruiz
@ 2022-01-10 1:55 ` David Bremner
2022-01-10 3:16 ` Jose Antonio Ortega Ruiz
1 sibling, 1 reply; 5+ messages in thread
From: David Bremner @ 2022-01-10 1:55 UTC (permalink / raw)
To: jao, notmuch; +Cc: jao
jao <jao@gnu.org> writes:
> This simply mimics what we already do for non-tree searches, and makes
> up for nicer buffer names. Note that this patch only applies to
> queries not coming from a search widget in the hello buffer.
>
Two questions:
1) Should this actually approximate what we do in
#'notmuch-search-buffer-title ? The buffer gets a name like
"*notmuch-saved-search-inbox*"
2) Should we do the same thing (whatever that is) for unthreaded mode
searches?
d
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] emacs: use query name for tree saved-search buffer names
2022-01-10 1:55 ` David Bremner
@ 2022-01-10 3:16 ` Jose Antonio Ortega Ruiz
2022-01-10 12:01 ` David Bremner
0 siblings, 1 reply; 5+ messages in thread
From: Jose Antonio Ortega Ruiz @ 2022-01-10 3:16 UTC (permalink / raw)
To: David Bremner, notmuch
On Sun, Jan 09 2022, David Bremner wrote:
> jao <jao@gnu.org> writes:
>
>> This simply mimics what we already do for non-tree searches, and makes
>> up for nicer buffer names. Note that this patch only applies to
>> queries not coming from a search widget in the hello buffer.
>>
>
> Two questions:
>
> 1) Should this actually approximate what we do in
> #'notmuch-search-buffer-title ? The buffer gets a name like
> "*notmuch-saved-search-inbox*"
oh, you're right. i have that function advised (because i prefer using
the unadorned query name), and thought i was being consistent. i think
we should. maybe we could consider adding a customizable format string
with default "*notmuch-saved-search-inbox-%s*" for cases like mine?
> 2) Should we do the same thing (whatever that is) for unthreaded mode
> searches?
i don't see any reason not to. i'll be happy to send a patch for both
cases.
cheers,
jao
--
Whenever you commend, add your reasons for doing so; it is this which
distinguishes the approbation of a man of sense from the flattery of
sycophants and admiration of fools. -Richard Steele (1672-1729)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] emacs: use query name for tree saved-search buffer names
2022-01-10 3:16 ` Jose Antonio Ortega Ruiz
@ 2022-01-10 12:01 ` David Bremner
0 siblings, 0 replies; 5+ messages in thread
From: David Bremner @ 2022-01-10 12:01 UTC (permalink / raw)
To: Jose Antonio Ortega Ruiz, notmuch
Jose Antonio Ortega Ruiz <jao@gnu.org> writes:
> On Sun, Jan 09 2022, David Bremner wrote:
>>
>> 1) Should this actually approximate what we do in
>> #'notmuch-search-buffer-title ? The buffer gets a name like
>> "*notmuch-saved-search-inbox*"
> oh, you're right. i have that function advised (because i prefer using
> the unadorned query name), and thought i was being consistent. i think
> we should. maybe we could consider adding a customizable format string
> with default "*notmuch-saved-search-inbox-%s*" for cases like mine?
Yes, sounds reasonable.
>
>> 2) Should we do the same thing (whatever that is) for unthreaded mode
>> searches?
>
> i don't see any reason not to. i'll be happy to send a patch for both
> cases.
sounds good.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-01-10 12:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-08 20:41 [PATCH] emacs: use query name for tree saved-search buffer names jao
2022-01-09 1:58 ` Jose Antonio Ortega Ruiz
2022-01-10 1:55 ` David Bremner
2022-01-10 3:16 ` Jose Antonio Ortega Ruiz
2022-01-10 12:01 ` David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).