unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] emacs: move From header addition to after header intern
@ 2022-09-20 20:18 Russell Sim
  2022-11-05 17:42 ` David Bremner
  0 siblings, 1 reply; 2+ messages in thread
From: Russell Sim @ 2022-09-20 20:18 UTC (permalink / raw)
  To: notmuch

OTHER-HEADERS are expected to be passed as strings, to match the
implementation of `compose-mail'.  But the "From" header is currently
expected to be passed as a symbol.  Instead the "From" header can be
safely added after converting all the headers to symbols.
---
 emacs/notmuch-mua.el | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
index ac878a61..3679d7d7 100644
--- a/emacs/notmuch-mua.el
+++ b/emacs/notmuch-mua.el
@@ -416,11 +416,6 @@ moved to the \"To:\" header."
     (let ((user-agent (funcall notmuch-mua-user-agent-function)))
       (unless (string-empty-p user-agent)
 	(push (cons 'User-Agent user-agent) other-headers))))
-  (unless (assq 'From other-headers)
-    (push (cons 'From (message-make-from
-		       (notmuch-user-name)
-		       (notmuch-user-primary-email)))
-	  other-headers))
   (notmuch-mua-pop-to-buffer (message-buffer-name "mail" to)
 			     (or switch-function
 				 (notmuch-mua-get-switch-function)))
@@ -439,6 +434,11 @@ moved to the \"To:\" header."
 	;; Cause `message-setup-1' to do things relevant for mail,
 	;; such as observe `message-default-mail-headers'.
 	(message-this-is-mail t))
+    (unless (assq 'From headers)
+      (push (cons 'From (message-make-from
+			 (notmuch-user-name)
+			 (notmuch-user-primary-email)))
+	    headers))
     (message-setup-1 headers yank-action send-actions return-action))
   (notmuch-fcc-header-setup)
   (notmuch-mua--remove-dont-reply-to-names)
--
2.37.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] emacs: move From header addition to after header intern
  2022-09-20 20:18 [PATCH] emacs: move From header addition to after header intern Russell Sim
@ 2022-11-05 17:42 ` David Bremner
  0 siblings, 0 replies; 2+ messages in thread
From: David Bremner @ 2022-11-05 17:42 UTC (permalink / raw)
  To: Russell Sim, notmuch

Russell Sim <russell.sim@gmail.com> writes:

> OTHER-HEADERS are expected to be passed as strings, to match the
> implementation of `compose-mail'.  But the "From" header is currently
> expected to be passed as a symbol.  Instead the "From" header can be
> safely added after converting all the headers to symbols.

applied to master

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-11-05 17:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-20 20:18 [PATCH] emacs: move From header addition to after header intern Russell Sim
2022-11-05 17:42 ` David Bremner

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).