unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Carl Worth <cworth@cworth.org>
To: Notmuch list <notmuch@notmuchmail.org>,
	Bart Trojanowski <bart@jukie.net>
Subject: Emacs: Problem viewing a thread after reading it once interface
Date: Fri, 04 Dec 2009 10:55:52 -0800	[thread overview]
Message-ID: <878wdifu13.fsf@yoom.home.cworth.org> (raw)
In-Reply-To: <877ht3hfh0.fsf@yoom.home.cworth.org>

[-- Attachment #1: Type: text/plain, Size: 1830 bytes --]

On Thu, 03 Dec 2009 14:15:07 -0800, Carl Worth <cworth@cworth.org> wrote:
>   * Showing a thread where the search matches only a subset of the
>     thread now opens only the matched messages (in addition to unread
>     messages).
> 
> This last feature is the big one---the rest all just happened to come
> along at the same time. One thing that I often do is read some giant
> thread and then tag a single message deep in that thread for dealing
> with later. And previously, doing a search for that tag would bring back
> the entire thread. Now, it opens only the message I'm actually looking
> for. So this is a very welcome change

Unfortunately, this change also introduces a major bug.

After I do a search such as tag:inbox and then view a resulting thread,
(and read it and archive it), then my search results still show that
thread result until I manually update the search view.

But, if I actually try to view that thread again from the search view,
it doesn't work. It previously worked since it would call "notmuch show"
with a query string of "thread:foo" but now calls it with "thread:foo
and tag:inbox" which now matches no messages.

The additional search term wasn't intended to change the returned
messages, (since we're passing the --entire-thread option to see all the
messages in the thread). It was only intended to restrict which messages
get the "match:1" marker added to them.

So maybe we need "notmuch show" to accept a second query string
to do something like:

	notmuch show tag:foo --matching tag:inbox

which will display all threads with messages matching "tag:foo" but then
mark only the messages matching "tag:inbox" with the "match:1" marker
for the UI to use.

What do you think, Bart? Did you run into a similar issue with the vim
interface?

-Carl

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

  parent reply	other threads:[~2009-12-04 18:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-03 22:15 Recent (and forthcoming) improvements to the emacs interface Carl Worth
2009-12-04  2:06 ` Marten Veldthuis
2009-12-04 17:16   ` Carl Worth
2009-12-04  8:38 ` Aneesh Kumar K. V
2009-12-04 17:10   ` Carl Worth
2009-12-04  8:58 ` Aneesh Kumar K. V
2009-12-04 17:13   ` Carl Worth
2009-12-04 18:55 ` Carl Worth [this message]
2009-12-04 21:20   ` Emacs: Problem viewing a thread after reading it once interface Bart Trojanowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878wdifu13.fsf@yoom.home.cworth.org \
    --to=cworth@cworth.org \
    --cc=bart@jukie.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).