From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id B2F79431FBD; Fri, 4 Dec 2009 16:56:58 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MtsIeXa8NAfm; Fri, 4 Dec 2009 16:56:57 -0800 (PST) Received: from yoom.home.cworth.org (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id A938B431FAE; Fri, 4 Dec 2009 16:56:57 -0800 (PST) Received: by yoom.home.cworth.org (Postfix, from userid 1000) id 620622542FB; Fri, 4 Dec 2009 16:56:57 -0800 (PST) From: Carl Worth To: Jameson Graef Rollins In-Reply-To: <20091205002050.GA26479@finestructure.net> References: <1259452657-27608-1-git-send-email-jrollins@finestructure.net> <87ocmee0sg.fsf@yoom.home.cworth.org> <20091205002050.GA26479@finestructure.net> Date: Fri, 04 Dec 2009 16:56:56 -0800 Message-ID: <878wdidyqv.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Cc: notmuch@notmuchmail.org Subject: Re: [PATCH 1/3] fix configure script to handle --prefix= and properly create Makefile.config X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Dec 2009 00:56:58 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Fri, 4 Dec 2009 19:20:50 -0500, Jameson Graef Rollins wrote: > > Your commit message has that flag word of "also" in it, and as it turns > > out, the removal of Makefile.config from the repository has actually > > happened already. But that was easy enough to fix. >=20 > I was thinking that the removal of the Makefile.config from the repo > went together with the new auto-generation of that file from configure > script. Do you think they still should have been separate patches? No, it was fine. It's just funny to me how often that word "also" in a commit message seems to end up being a predictor for things later, (like this case where half of a patch is already implemented, or much worse, how often a bisect lands on a commit that makes multiple changes). So I was really just expressing amusement at seeing it again. > > > +# option parsing > > > +for option; do > > > + if [ "${option%=3D*}" =3D '--prefix' ] ; then > > > + PREFIX=3D"${option#*=3D}" > > > + fi > > > +done > >=20 > > I've gone ahead and committed that now. Then I noticed that we should > > really use ${option%%=3D*} to support the case of an option value > > containing an '=3D' character. So I fixed that. >=20 > Ah, good catch. Sorry about that.=20=20 No worries. I was just impressed at the tiny amount of code needed for the parsing here, so ended up looking closer to understand it. > Autoconf terrifies me, so I agree I'm quite happy with the simple > configure script we have right now. If it gets the job done without > having to deal with autoconf then that's great in my book. Cool. At least not everyone thinks I'm crazy then. That's encouraging. :-) =2DCarl --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iD8DBQFLGa/Z6JDdNq8qSWgRAjTaAKCCQ0n3l9Ae6Y7mWwaoJezCbBDPagCfSEwT MXBUsNBliQ3aQFzRjHlL0V8= =+Rd8 -----END PGP SIGNATURE----- --=-=-=--