From: Carl Worth <cworth@cworth.org>
To: Jameson Graef Rollins <jrollins@finestructure.net>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH 1/3] fix configure script to handle --prefix= and properly create Makefile.config
Date: Fri, 04 Dec 2009 16:56:56 -0800 [thread overview]
Message-ID: <878wdidyqv.fsf@yoom.home.cworth.org> (raw)
In-Reply-To: <20091205002050.GA26479@finestructure.net>
[-- Attachment #1: Type: text/plain, Size: 1714 bytes --]
On Fri, 4 Dec 2009 19:20:50 -0500, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> > Your commit message has that flag word of "also" in it, and as it turns
> > out, the removal of Makefile.config from the repository has actually
> > happened already. But that was easy enough to fix.
>
> I was thinking that the removal of the Makefile.config from the repo
> went together with the new auto-generation of that file from configure
> script. Do you think they still should have been separate patches?
No, it was fine. It's just funny to me how often that word "also" in a
commit message seems to end up being a predictor for things later, (like
this case where half of a patch is already implemented, or much worse,
how often a bisect lands on a commit that makes multiple changes).
So I was really just expressing amusement at seeing it again.
> > > +# option parsing
> > > +for option; do
> > > + if [ "${option%=*}" = '--prefix' ] ; then
> > > + PREFIX="${option#*=}"
> > > + fi
> > > +done
> >
> > I've gone ahead and committed that now. Then I noticed that we should
> > really use ${option%%=*} to support the case of an option value
> > containing an '=' character. So I fixed that.
>
> Ah, good catch. Sorry about that.
No worries. I was just impressed at the tiny amount of code needed for
the parsing here, so ended up looking closer to understand it.
> Autoconf terrifies me, so I agree I'm quite happy with the simple
> configure script we have right now. If it gets the job done without
> having to deal with autoconf then that's great in my book.
Cool. At least not everyone thinks I'm crazy then. That's
encouraging. :-)
-Carl
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2009-12-05 0:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-28 23:57 [PATCH 1/3] fix configure script to handle --prefix= and properly create Makefile.config Jameson Graef Rollins
2009-11-28 23:57 ` [PATCH 2/3] add checking for zlib development libraries to configure script Jameson Graef Rollins
2009-11-28 23:57 ` [PATCH 3/3] fix Makefile.local to install bash completion definitions as not executable Jameson Graef Rollins
2009-12-05 0:16 ` Carl Worth
2009-12-05 0:21 ` Jameson Graef Rollins
2009-11-29 10:46 ` [PATCH 2/3] add checking for zlib development libraries to configure script Mikhail Gusarov
2009-11-29 12:50 ` david
2009-12-05 0:12 ` [PATCH 1/3] fix configure script to handle --prefix= and properly create Makefile.config Carl Worth
2009-12-05 0:20 ` Jameson Graef Rollins
2009-12-05 0:56 ` Carl Worth [this message]
2009-12-05 8:59 ` Ingmar Vanhassel
2009-12-05 23:05 ` Carl Worth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878wdidyqv.fsf@yoom.home.cworth.org \
--to=cworth@cworth.org \
--cc=jrollins@finestructure.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).