From: Carl Worth <cworth@cworth.org>
To: david@tethera.net, notmuch@notmuchmail.org
Subject: Re: [PATCH] Add an "--output=(json|text|)" command-line option to both notmuch-search and notmuch-show.
Date: Tue, 23 Feb 2010 11:56:10 -0800 [thread overview]
Message-ID: <878wajwwth.fsf@yoom.home.cworth.org> (raw)
In-Reply-To: <1261141195-5469-1-git-send-email-david@tethera.net>
[-- Attachment #1: Type: text/plain, Size: 3222 bytes --]
On Fri, 18 Dec 2009 08:59:55 -0400, david@tethera.net wrote:
> From: Scott Robinson <scott@quadhome.com>
Hi Scott (and David),
I'm finally getting around to looking closely at the JSON patches
(hurrah!). Here are some comments:
> In the case of notmuch-show, "--output=json" also implies
> "--entire-thread" as the thread structure is implicit in the emitted
> document tree.
I think we've all agreed to use --output for selecting what to print and
to instead use --format for how to format it. I also think David's got a
patch to change that, but if we have to change the current patch anyway,
we might change that at the same time.
> --- /dev/null
> +++ b/json.c
> @@ -0,0 +1,73 @@
> +/* notmuch - Not much of an email program, (just index and search)
> + *
> + * Copyright © 2009 Carl Worth
> + * Copyright © 2009 Keith Packard
I know I didn't contribute any code to this file, so my name shouldn't
be here. Scott, I imagine you have made some non-trivial contributions
so your name (or suitable copyright-claiming entity) should be here.
> + * Authors: Carl Worth <cworth@cworth.org>
> + * Keith Packard <keithp@keithp.com>
Same thing here.
> +/*
> + * json_quote_str derived from cJSON's print_string_ptr,
> + * Copyright (c) 2009 Dave Gamble
> + */
Thanks for attributing the source here, but let's please keep all the
copyright statements up at the top of the file.
It would still be reasonable to have a comment at this point that this
particular code came from Dave Gamble and cJSON. But it should also
mention the license under which the code is being integrated.
I suggest leaving the notmuch-standar GPLv3+ blurb at the top of the
file, but then quoting the license itself of the external code, (it's a
short MIT-style license, right?).
> +char *
> +json_quote_str(const void *ctx, const char *str)
It would be nice to have a little comment here describing what the
function does, (what characters get quoted and how, that the return
value is talloced with 'ctx' as a parent, and perhaps a pointer to the
appropriate JSON reference/specification).
But I definitely like this nice little function as opposed to some JSON
library. Thanks!
> +typedef struct search_format {
> + const char *results_start;
> + const char *thread_start;
> + void (*thread) (const void *ctx,
> + const char *id,
> + const time_t date,
> + const int matched,
> + const int total,
> + const char *authors,
> + const char *subject);
...
Definitely missing at least a quick comment for internal documentation
here as well. But I do like the way this works.
> --- a/notmuch.c
> +++ b/notmuch.c
> @@ -162,6 +162,11 @@ command_t commands[] = {
> "\n"
> "\t\tSupported options for search include:\n"
> "\n"
> + "\t\t--output=(json|text)\n"
> + "\n"
> + "\t\t\tPresents the results in either JSON or plain-text\n"
> + "\t\t\tformat, which is the default.\n"
> + "\n"
Thanks for adding the documentation here. But please add to notmuch.1 as
well.
This all looks really great. And I can't wait to apply it and play with
it more.
-Carl
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2010-02-23 19:56 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-13 23:21 RFC: output json from notmuch? David Bremner
2009-12-13 23:26 ` David Bremner
2009-12-14 0:05 ` Scott Robinson
2009-12-14 0:42 ` David Bremner
2009-12-14 22:41 ` Carl Worth
2009-12-14 22:34 ` Carl Worth
2009-12-14 0:07 ` Marten Veldthuis
2009-12-14 22:30 ` Carl Worth
2009-12-14 23:10 ` David Bremner
2009-12-18 5:33 ` [PATCH] JSON output for notmuch-search and notmuch-show Scott Robinson
2009-12-18 12:59 ` [PATCH] Add an "--output=(json|text|)" command-line option to both " david
2009-12-18 17:33 ` Carl Worth
2009-12-18 18:45 ` Scott Robinson
2009-12-19 0:36 ` David Bremner
2009-12-23 5:58 ` Carl Worth
2009-12-19 14:55 ` Prototype of --show option to control what is shown david
2009-12-19 14:55 ` [PATCH 1/3] rename option to select output format to --format from --output david
2009-12-19 14:55 ` [PATCH 2/3] notmuch-show.c: make calls to format functions conditional david
2009-12-19 14:55 ` [PATCH 3/3] notmuch-show.c: prototype tabular output format, with output control david
2010-03-09 19:51 ` Carl Worth
2010-03-09 20:19 ` David Bremner
2010-03-10 9:25 ` Carl Worth
2010-03-10 15:34 ` David Bremner
2009-12-20 20:31 ` [PATCH] notmuch-query.el: new file to support access to the notmuch database david
2009-12-21 17:21 ` Carl Worth
2009-12-21 18:01 ` David Bremner
2010-02-24 12:52 ` [PATCH v2] " david
2010-04-05 16:46 ` [PATCH v3] " david
2010-04-05 16:59 ` David Edmondson
2010-04-05 18:13 ` Carl Worth
2010-02-23 19:56 ` Carl Worth [this message]
2010-02-23 21:00 ` JSON output as default [was: Re: [PATCH] Add an "--output=(json|text|)" command-line option...] Jameson Rollins
2010-02-23 23:35 ` Carl Worth
2010-02-24 13:54 ` Sebastian Spaeth
2009-12-18 17:31 ` [PATCH] JSON output for notmuch-search and notmuch-show Carl Worth
2009-12-18 18:47 ` Scott Robinson
2009-12-23 5:48 ` Carl Worth
2009-12-31 8:54 ` Scott Robinson
2009-12-31 12:49 ` David Bremner
2009-12-25 12:53 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878wajwwth.fsf@yoom.home.cworth.org \
--to=cworth@cworth.org \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).