On Sun, 14 Nov 2010 22:54:30 +0100, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
> Break notmuch-test whenever a test script returns non-zero status.
> This happens either when some test from the script fails or when there
> is an error in the script.
> 
> This is especially useful in the latter case since the error may not
> appear in the final aggregated results.

Hi Michal,

I'm reverting this patch now, with the following commit message:

    Revert "test: Break on test script (or other) error"
    
    This reverts commit f22a7ec1e28d1264cf9d67d78796b8ab22e09a35.
    
    Interrupting the test suite due to an actual bug in a test script
    would be just fine, but interrupting the run of the entire test suite
    at the first test failure is unacceptable.

As I say there, if we could detect an actual bug in the test script, and
only interrupt then, then that would be great, (perhaps using some value
other than 1 for the test-failure indication in test_done?).

As it is, though, I'm implementing a fix for a BROKEN test case in one
script, and that's causing a failure in an earlier test script. And the
interruption is causing me pain since the script I *really* want to run
isn't even getting run.

Let me know if you've got some good ideas for a better fix here.

-Carl

-- 
carl.d.worth@intel.com