From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>,
Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH] Use message-field-value instead of message-fetch-field in FCC header setup.
Date: Mon, 09 May 2011 09:32:42 -0700 [thread overview]
Message-ID: <878vufsul1.fsf@servo.factory.finestructure.net> (raw)
In-Reply-To: <1304942780-4228-1-git-send-email-dmitry.kurochkin@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 622 bytes --]
On Mon, 9 May 2011 16:06:20 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> For message-fetch-field the buffer is expected to be narrowed to
> just the header of the message. That is not the case when
> notmuch-fcc-header-setup is run, hence a wrong header value may be
> returned. E.g. when forwarding an
> email, (message-fetch-field "From") returns the From header value
> of the forwarded email.
>
> Message-field-value is the same as message-fetch-field, only
> narrows the buffer to the headers first.
Hey, Dmitry. This is a nice clean fix. I've applied it to the r-c/0.6.
jamie.
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
prev parent reply other threads:[~2011-05-09 16:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-09 12:06 [PATCH] Use message-field-value instead of message-fetch-field in FCC header setup Dmitry Kurochkin
2011-05-09 16:32 ` Jameson Graef Rollins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878vufsul1.fsf@servo.factory.finestructure.net \
--to=jrollins@finestructure.net \
--cc=dmitry.kurochkin@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).