unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Carl Worth <cworth@cworth.org>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] tests: add a test for symbol hiding side effects
Date: Thu, 23 Jun 2011 15:26:17 -0700	[thread overview]
Message-ID: <878vssdw1i.fsf@yoom.home.cworth.org> (raw)
In-Reply-To: <878vssrgl3.fsf@zancas.localnet>

[-- Attachment #1: Type: text/plain, Size: 617 bytes --]

On Thu, 23 Jun 2011 07:24:08 -0300, David Bremner <david@tethera.net> wrote:
> On Wed, 22 Jun 2011 09:02:36 -0300, david@tethera.net wrote:
> > From: David Bremner <bremner@debian.org>
> > 
> > The worry here is that a binary linking with libnotmuch might lose
> > access to Xapian::Error symbols because libnotmuch hides them.
> 
> After some helpful feedback from jrollins and amdragon on IRC, I have
> pushed an updated version of this. The guts of the updated test are as
> follows:

Lovely stuff! I so love having new features come along with their own tests.

-Carl

-- 
carl.d.worth@intel.com

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

      reply	other threads:[~2011-06-23 22:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-22  1:08 david
2011-06-22  1:08 ` [PATCH 1/2] libnotmuch: add linker script to declare only notmuch_* symbols as global david
2011-06-22  1:08 ` [PATCH 2/2] remove Xapian exceptions symbols from libnotmuch1.symbols david
2011-06-22  2:05 ` hiding xapian symbols Daniel Kahn Gillmor
2011-06-22  2:57   ` David Bremner
2011-06-22 12:02     ` [PATCH] tests: add a test for symbol hiding side effects david
2011-06-23 10:24       ` David Bremner
2011-06-23 22:26         ` Carl Worth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878vssdw1i.fsf@yoom.home.cworth.org \
    --to=cworth@cworth.org \
    --cc=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).