From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 8C5A0431FD0 for ; Fri, 26 Aug 2011 05:46:32 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.3 X-Spam-Level: X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YfNCxh-ty3aJ for ; Fri, 26 Aug 2011 05:46:32 -0700 (PDT) Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 11F19431FB6 for ; Fri, 26 Aug 2011 05:46:31 -0700 (PDT) Received: from zancas.localnet (fctnnbsc36w-156034065066.pppoe-dynamic.High-Speed.nb.bellaliant.net [156.34.65.66]) (authenticated bits=0) by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id p7QCkROg010388 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Fri, 26 Aug 2011 09:46:28 -0300 Received: from bremner by zancas.localnet with local (Exim 4.76) (envelope-from ) id 1Qwvnn-0002nD-8k; Fri, 26 Aug 2011 09:46:27 -0300 From: David Bremner To: richardmurri@gmail.com, notmuch@notmuchmail.org Subject: Re: Fix for emacs 24 In-Reply-To: <877h6x6oor.fsf@veracitynetworks.com> References: <877h6x6oor.fsf@veracitynetworks.com> User-Agent: Notmuch/0.7 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Fri, 26 Aug 2011 09:46:27 -0300 Message-ID: <878vqgz6fw.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Aug 2011 12:46:32 -0000 On Mon, 01 Aug 2011 11:12:36 -0600, richardmurri@gmail.com wrote: > Emacs added another parameter to the send mail functions. This caused > emacs to error out. > (defun notmuch-mua-mail (&optional to subject other-headers continue > - switch-function yank-action send-actions) > + switch-function yank-action send-actions > + return-action) Thanks for sending a patch. I'm sure we need lots of help to get notmuch working well with emacs24. Some comments about your patch - It would be nice to have a bit more informative single line summary to start the patch. - I don't really understand from the long commit message what problem this fixes. I take it some function outside of notmuch is calling notmuch-mua-mail? - The convention on the notmuch list is to use "git send-email" if you can. This makes it easier to apply patches. Any discussion not meant to be part of the commit message can go after the --- at the end of the commit message (and I admit that isn't very obvious). Thanks again, and welcome to the team ;) d