[PATCH] python: use wrapped notmuch_*_t types instead of raw pointers

[PATCH] python: use wrapped notmuch_*_t types instead of raw pointers

[Thomas Jost]

Now that types are checked correctly, we also need to make sure that all the
arguments actually are instances of these types. Otherwise the function calls
will fail and raise an exception similar to this one:
   ctypes.ArgumentError: argument 3: <type 'exceptions.TypeError'>: expected
   LP_LP_NotmuchMessageS instance instead of pointer to c_void_p
---
 bindings/python/notmuch/database.py |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/bindings/python/notmuch/database.py b/bindings/python/notmuch/database.py
index 25b4b1b..c24555e 100644
--- a/bindings/python/notmuch/database.py
+++ b/bindings/python/notmuch/database.py
@@ -378,7 +378,7 @@ class Database(object):
                       be added.
         """
         self._assert_db_is_initialized()
-        msg_p = c_void_p()
+        msg_p = NotmuchMessageP()
         status = self._add_message(self._db, _str(filename), byref(msg_p))
 
         if not status in [STATUS.SUCCESS, STATUS.DUPLICATE_MESSAGE_ID]:
@@ -446,7 +446,7 @@ class Database(object):
                     the database was not intitialized.
         """
         self._assert_db_is_initialized()
-        msg_p = c_void_p()
+        msg_p = NotmuchMessageP()
         status = Database._find_message(self._db, _str(msgid), byref(msg_p))
         if status != STATUS.SUCCESS:
             raise NotmuchError(status)
@@ -479,7 +479,7 @@ class Database(object):
 
         *Added in notmuch 0.9*"""
         self._assert_db_is_initialized()
-        msg_p = c_void_p()
+        msg_p = NotmuchMessageP()
         status = Database._find_message_by_filename(self._db, _str(filename),
                                                     byref(msg_p))
         if status != STATUS.SUCCESS:
-- 
1.7.7.4

Re: [PATCH] python: use wrapped notmuch_*_t types instead of raw pointers

[Sebastian Spaeth]

[-- Attachment #1: Type: text/plain, Size: 457 bytes --]

On Tue,  6 Dec 2011 11:03:22 +0100, Thomas Jost <schnouki@schnouki.net> wrote:
> Now that types are checked correctly, we also need to make sure that all the
> arguments actually are instances of these types. Otherwise the function calls
> will fail and raise an exception similar to this one:
>    ctypes.ArgumentError: argument 3: <type 'exceptions.TypeError'>: expected
>    LP_LP_NotmuchMessageS instance instead of pointer to c_void_p

Thanks, Pushed.

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]