From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 708D1429E33 for ; Thu, 5 Jan 2012 19:39:34 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.3 X-Spam-Level: X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FH+2Sx6AIlVY for ; Thu, 5 Jan 2012 19:39:33 -0800 (PST) Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id C704A429E32 for ; Thu, 5 Jan 2012 19:39:33 -0800 (PST) Received: from zancas.localnet (fctnnbsc36w-156034072155.pppoe-dynamic.High-Speed.nb.bellaliant.net [156.34.72.155]) (authenticated bits=0) by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id q063dUh8000781 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Thu, 5 Jan 2012 23:39:31 -0400 Received: from bremner by zancas.localnet with local (Exim 4.77) (envelope-from ) id 1Rj0eQ-0006sS-EU; Thu, 05 Jan 2012 23:39:30 -0400 From: David Bremner To: David Edmondson , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: Helpers for notmuch developers. In-Reply-To: <1325685678-12710-1-git-send-email-dme@dme.org> References: <1325685678-12710-1-git-send-email-dme@dme.org> User-Agent: Notmuch/0.10.2+167~gadf1058 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Thu, 05 Jan 2012 23:39:30 -0400 Message-ID: <878vllxzwt.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jan 2012 03:39:34 -0000 On Wed, 4 Jan 2012 14:01:18 +0000, David Edmondson wrote: > --- > > I've been using this for a few days and decided to share it to get > feedback. Reviewing patches can be tedious, so I tried to make things > a little simpler. > I didn't have a very thorough look at the code, but I like the functionality. Especially hitting q a few times from magit and being in the right place to reply. > General management (i.e. keeping up to date) of the repository it uses > is your responsibility, as is cleaning out old branches. You can, of > course, just delete the temporary repository after using it - the code > will re-create it next time. maybe the branches could be under some namespace that makes this easy? > +(defvar notmuch-dev-temporary-repository-name (concat "notmuch-dev-" (user-login-name)) > + "The name of the temporary repository.") Do we care about security at all in this context? I'm always a bit nervous about creating predictably named files/directories in publicly writable places. > + ;; Causes us to switch to the magit buffer - is that unfortunate in > + ;; some situations? > + (magit-status notmuch-dev-temporary-repository-path)) I found it to be a pleasant surprise. > + (shell-command > + (concat > + notmuch-command " show --format=mbox " (shell-quote-argument search-terms) > + " | " > + "git am --quiet")) > + Hmm. A knee jerk reaction is not to like this, like seeing system in C code. But I don't have a better solution off hand. d