From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 31E5C429E52 for ; Sun, 12 Feb 2012 12:39:23 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.29 X-Spam-Level: X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 096dP51N22y5 for ; Sun, 12 Feb 2012 12:39:20 -0800 (PST) Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu [131.215.239.19]) by olra.theworths.org (Postfix) with ESMTP id C0D65431FAE for ; Sun, 12 Feb 2012 12:39:20 -0800 (PST) Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) by earth-doxen-postvirus (Postfix) with ESMTP id 3929866E011D; Sun, 12 Feb 2012 12:39:20 -0800 (PST) X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new Received: from finestructure.net (cpe-76-174-137-84.socal.res.rr.com [76.174.137.84]) (Authenticated sender: jrollins) by earth-doxen-submit (Postfix) with ESMTP id 5D07566E00F8; Sun, 12 Feb 2012 12:39:16 -0800 (PST) Received: by finestructure.net (Postfix, from userid 1000) id 0EFF74DE; Sun, 12 Feb 2012 12:39:16 -0800 (PST) From: Jameson Graef Rollins To: Mark Walters , notmuch@notmuchmail.org Subject: Re: [RFC PATCH v2 0/3] notmuch-pick: an emacs threaded message view with split-pane In-Reply-To: <1329072579-27340-1-git-send-email-markwalters1009@gmail.com> References: <1329072579-27340-1-git-send-email-markwalters1009@gmail.com> User-Agent: Notmuch/0.11.1+156~gde94716 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Sun, 12 Feb 2012 12:39:13 -0800 Message-ID: <878vk73hxq.fsf@servo.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Feb 2012 20:39:23 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Sun, 12 Feb 2012 18:49:36 +0000, Mark Walters wrote: > Here is a rebased version of the notmuch-pick patch set > id:"87d39k1gvi.fsf@qmul.ac.uk". It now applies directly=20 > to master since Jani's notmuch-show command line parsing=20 > has been pushed. Hey, Mark. Thanks for working on this. However, none of the patches have commit messages, so there's no explanation for what any of the patches are supposed to do. This is particularly bothersome for the first patch, which introduces a lot of unexplained changes to the cli. I think I would like to review this patch set, since I think I'm interested in the functionality it may be introducing, but without any commit messages or explanation what the patches are meant to do it's kind of a non starter for me. jamie. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCAAGBQJPOCNxAAoJEO00zqvie6q8I2MQAJHyHEEazqeM5SnBXsnKy9Tc fA4fwKSilBI8vcSYfsJ5hEHSatyHGcDc0yQJe9tkDtiWO3rCCpYea6CQSS8ImNbw x4yCqzCWIUWoUiOGgYHBAsiVYxNkJcC9Vx3JuTRLCxfmZFQwBBf7NwSX5FlIxwH1 aWEGZ2WtQNHI5kS7tIx/bpUPISpFIyipDXcnrbQNKygtnfKJPaFJ/YqIHLYslNlq 6liuDW8XXXQac+n0uFWo/aWxa3JQp+jV93kE7JDmAx9jUqMjtTyhFZhpPwrhbRPw qzUnqAysbGQgmR08iH6TUgMc6s5KPaJBR4HqMDGFvJ/nEFXS22dm+Ty96r+5qf/t dAVDa4MhaM4R6NREeiwNmyEe8JKO/01Z4QSEEn/zge3ZDKGE42r5WIoZVqh5ScmE iz+OGpYkzBg5RfRcf9SUnyXxcO/iPuRG8FYvxcUzzVqRK6dljSWtJ9PHR+nwVKa9 RcR42PTYPAih5BVQTQjcjGy0wsXNhKcjqMM6KaERc+yZRaz1z3OfHsN5FUBQTE99 kGjCsF1l/3RM+kq2lPyw6OIoADkEdPSPsI66txYVODipO0sjDtzwe1GsOcN5CE7O 61E0IXZZyY5wQ4C4dLg7BYW1NAoW+RQuQ+E/cWt3fdJfqSJ4yLVcfghrOfik4OG7 13ZVj39XV1xfkoD37SUr =0QL+ -----END PGP SIGNATURE----- --=-=-=--