From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [RFC PATCH v2 0/3] notmuch-pick: an emacs threaded message view with split-pane
Date: Sun, 12 Feb 2012 12:39:13 -0800 [thread overview]
Message-ID: <878vk73hxq.fsf@servo.finestructure.net> (raw)
In-Reply-To: <1329072579-27340-1-git-send-email-markwalters1009@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 820 bytes --]
On Sun, 12 Feb 2012 18:49:36 +0000, Mark Walters <markwalters1009@gmail.com> wrote:
> Here is a rebased version of the notmuch-pick patch set
> id:"87d39k1gvi.fsf@qmul.ac.uk". It now applies directly
> to master since Jani's notmuch-show command line parsing
> has been pushed.
Hey, Mark. Thanks for working on this. However, none of the patches
have commit messages, so there's no explanation for what any of the
patches are supposed to do. This is particularly bothersome for the
first patch, which introduces a lot of unexplained changes to the cli.
I think I would like to review this patch set, since I think I'm
interested in the functionality it may be introducing, but without any
commit messages or explanation what the patches are meant to do it's
kind of a non starter for me.
jamie.
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2012-02-12 20:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-12 18:49 [RFC PATCH v2 0/3] notmuch-pick: an emacs threaded message view with split-pane Mark Walters
2012-02-12 18:49 ` [RFC PATCH v2 1/3] cli: notmuch-show changes to support pick Mark Walters
2012-02-12 21:08 ` Daniel Schoepe
2012-02-12 22:08 ` Mark Walters
2012-02-12 18:49 ` [RFC PATCH v2 2/3] emacs: changes to other files to support notmuch-pick Mark Walters
2012-02-12 22:27 ` Mark Walters
2012-02-12 18:49 ` [RFC PATCH v2 3/3] emacs: add notmuch-pick itself Mark Walters
2012-02-12 20:39 ` Jameson Graef Rollins [this message]
2012-02-12 21:51 ` [RFC PATCH v2 0/3] notmuch-pick: an emacs threaded message view with split-pane Mark Walters
2012-02-13 1:20 ` [RFC PATCH v3 00/11] " Mark Walters
2012-02-14 12:28 ` Mark Walters
2012-02-14 15:21 ` Austin Clements
2012-02-15 9:27 ` Mark Walters
2012-02-13 1:20 ` [RFC PATCH v3 01/11] cli: add --headers_only option to notmuch-show.c Mark Walters
2012-02-13 1:20 ` [RFC PATCH v3 02/11] cli: add sort options " Mark Walters
2012-02-13 1:20 ` [RFC PATCH v3 03/11] cli: add --thread= option to notmuch-show Mark Walters
2012-02-13 1:20 ` [RFC PATCH v3 04/11] emacs: add entry to notmuch-pick from notmuch-hello.el Mark Walters
2012-02-13 1:20 ` [RFC PATCH v3 05/11] emacs: add defcustom group for notmuch-pick Mark Walters
2012-02-13 1:20 ` [RFC PATCH v3 06/11] emacs: add extra parameters option to notmuch-query-get-threads Mark Walters
2012-02-13 1:20 ` [RFC PATCH v3 07/11] emacs: add entry to notmuch-pick from notmuch.el Mark Walters
2012-02-13 1:20 ` [RFC PATCH v3 08/11] emacs: add the entry to notmuch-pick to notmuch-show.el Mark Walters
2012-02-13 1:20 ` [RFC PATCH v3 09/11] emacs: make notmuch-show return its buffer Mark Walters
2012-02-13 1:20 ` [RFC PATCH v3 10/11] emacs: notmuch-show.el just show the actual matching messages Mark Walters
2012-02-13 1:20 ` [RFC PATCH v3 11/11] emacs: add notmuch-pick itself Mark Walters
2012-02-13 9:05 ` [RFC PATCH v2 0/3] notmuch-pick: an emacs threaded message view with split-pane Aneesh Kumar K.V
2012-02-13 18:16 ` Mark Walters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878vk73hxq.fsf@servo.finestructure.net \
--to=jrollins@finestructure.net \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).