From: David Bremner <david@tethera.net>
To: Stefano Zacchiroli <zack@upsilon.cc>, notmuch@notmuchmail.org
Cc: 628018-quiet@bugs.debian.org
Subject: Re: [PATCH v2]: contrib/notmuch-mutt
Date: Fri, 30 Mar 2012 18:38:53 -0300 [thread overview]
Message-ID: <878vihpy4y.fsf@zancas.localnet> (raw)
In-Reply-To: <20120329133538.GA12117@upsilon.cc>
On Thu, 29 Mar 2012 15:35:38 +0200, Stefano Zacchiroli <zack@upsilon.cc> wrote:
>
> Here is an updated set of patches, which I consider final for inclusion
> of notmuch-mutt as part of notmuch contrib/. AFAICT I've implemented
> all changes that have been requested either on this list or in private
> mail to me: renaming, Debian packaging, XDG userdir support, shell
> quoting in all notmuch calls. TTBOMK, no further changes have been
> requested.
I tried out these patches, and they seem to work (to the limit of my
mutt knowledge). I did notice a minor grammar issue in the DESCRIPTION
of the man page, "capable of populating maildir" should be "a maildir"
or "maildirs". In general for notmuch commit messages we expect a bit
more of the rationale for the commit; in this case a few lines about the
general purpose and (conceiveably) the implementation of notmuch-mutt
would be welcome. See ebd1adc55b for a (probably overkill) example.
d
next prev parent reply other threads:[~2012-03-30 21:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-25 13:13 mutt-notmuch in notmuch contrib David Bremner
2012-03-29 13:35 ` [PATCH v2]: contrib/notmuch-mutt Stefano Zacchiroli
2012-03-30 21:38 ` David Bremner [this message]
2012-03-31 0:35 ` David Bremner
2012-03-31 8:38 ` Stefano Zacchiroli
2012-04-02 20:42 ` David Bremner
2012-04-02 21:48 ` James Vasile
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878vihpy4y.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=628018-quiet@bugs.debian.org \
--cc=notmuch@notmuchmail.org \
--cc=zack@upsilon.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).