unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Mark Walters <markwalters1009@gmail.com>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: v5 of Batch-tag dump/restore patches
Date: Sun, 09 Dec 2012 17:17:27 +0000	[thread overview]
Message-ID: <878v97m9g8.fsf@qmul.ac.uk> (raw)
In-Reply-To: <877gorqtai.fsf@zancas.localnet>


This series looks good to me too. +1

Best wishes

Mark

On Sun, 09 Dec 2012, David Bremner <david@tethera.net> wrote:
> david@tethera.net writes:
>
>> Yet another version. Luckily we all use threaded mailreaders, right?
>>
>
> A few fixups Jani mentioned in IRC:
>
> commit 4cbd366d3cd29b5d26b36f3744c26b0853b23437
> Author: David Bremner <bremner@debian.org>
> Date:   Sun Dec 9 08:49:29 2012 -0400
>
>     remove unused sigatomic_t from notmuch-restore
>     
>     I guess this must be cut and paste error from Jani's notmuch-tag code
>
> diff --git a/notmuch-restore.c b/notmuch-restore.c
> index dba882b..40596a8 100644
> --- a/notmuch-restore.c
> +++ b/notmuch-restore.c
> @@ -23,7 +23,6 @@
>  #include "tag-util.h"
>  #include "string-util.h"
>  
> -static volatile sig_atomic_t interrupted;
>  static regex_t regex;
>  
>  static int
>
> commit 75b2fab1874fc9f0bab514fe832cfd85d1319877
> Author: David Bremner <bremner@debian.org>
> Date:   Sun Dec 9 08:47:12 2012 -0400
>
>     enum fixup for tag-utils
>
> diff --git a/tag-util.c b/tag-util.c
> index e7233ab..eab482f 100644
> --- a/tag-util.c
> +++ b/tag-util.c
> @@ -16,7 +16,7 @@ struct _tag_op_list_t {
>      size_t size;
>  };
>  
> -static int
> +static tag_parse_status_t
>  line_error (tag_parse_status_t status,
>  	    const char *line,
>  	    const char *format, ...)
> @@ -31,7 +31,7 @@ line_error (tag_parse_status_t status,
>      return status;
>  }
>  
> -int
> +tag_parse_status_t
>  parse_tag_line (void *ctx, char *line,
>  		tag_op_flag_t flags,
>  		char **query_string,
> @@ -56,7 +56,7 @@ parse_tag_line (void *ctx, char *line,
>  
>      /* Skip empty and comment lines. */
>      if (*tok == '\0' || *tok == '#') {
> -	ret = 2;
> +	ret = TAG_PARSE_SKIPPED;
>  	goto DONE;
>      }
>  
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

  parent reply	other threads:[~2012-12-09 17:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-08 22:56 v5 of Batch-tag dump/restore patches david
2012-12-08 22:56 ` [Patch v5 01/11] notmuch-dump: add --format=(batch-tag|sup) david
2012-12-08 22:56 ` [Patch v5 02/11] test: add sanity check for dump --format=batch-tag david
2012-12-08 22:56 ` [Patch v5 03/11] util: add string-util.[ch] david
2012-12-08 22:56 ` [Patch v5 04/11] tag-util.[ch]: New files for common tagging routines david
2012-12-08 22:56 ` [Patch v5 05/11] notmuch-restore: add support for input format 'batch-tag' david
2012-12-08 22:56 ` [Patch v5 06/11] notmuch-restore: normalize case of error messages david
2012-12-08 22:56 ` [Patch v5 07/11] test: update dump-restore roundtripping test for batch-tag format david
2012-12-08 22:56 ` [Patch v5 08/11] test: second set of dump/restore --format=batch-tag tests david
2012-12-08 22:56 ` [Patch v5 09/11] test/dump-restore: add test for warning/error messages david
2012-12-08 22:57 ` [Patch v5 10/11] notmuch-{dump, restore}.1: document new format options david
2012-12-08 22:57 ` [Patch v5 11/11] tag-util: optimization of tag application david
2012-12-09 12:55 ` v5 of Batch-tag dump/restore patches David Bremner
2012-12-09 13:46   ` Jani Nikula
2012-12-09 17:17   ` Mark Walters [this message]
2012-12-09 23:05 ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878v97m9g8.fsf@qmul.ac.uk \
    --to=markwalters1009@gmail.com \
    --cc=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).