From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 48307431FB6 for ; Wed, 26 Dec 2012 19:24:02 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hQUe00uJARxk for ; Wed, 26 Dec 2012 19:24:01 -0800 (PST) Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 7816B431FAF for ; Wed, 26 Dec 2012 19:24:01 -0800 (PST) Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net ([156.34.82.78] helo=zancas.localnet) by tesseract.cs.unb.ca with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1To44a-0003F7-Ge; Wed, 26 Dec 2012 23:23:56 -0400 Received: from bremner by zancas.localnet with local (Exim 4.80) (envelope-from ) id 1To44U-0006cb-Qc; Wed, 26 Dec 2012 23:23:50 -0400 From: David Bremner To: Michael Forney , Adrien Bustany , notmuch@notmuchmail.org Subject: Re: [PATCH v2 0/2] Add flush/reopen methods to notmuch_database_t In-Reply-To: <1355276420-ner-1510@novus> References: <1342723401-26103-1-git-send-email-adrien@bustany.org> <1350510742-13447-1-git-send-email-adrien@bustany.org> <1355276420-ner-1510@novus> User-Agent: Notmuch/0.14+213~g4af1ac6 (http://notmuchmail.org) Emacs/24.2.1 (x86_64-pc-linux-gnu) Date: Wed, 26 Dec 2012 23:23:50 -0400 Message-ID: <878v8kqit5.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-Spam_bar: - X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Dec 2012 03:24:02 -0000 Michael Forney writes: > On Thu, 18 Oct 2012 00:52:20 +0300, Adrien Bustany wrote: >> The code of the patches in unchanged, but the formatting issues are now >> hopefully fixed. > > I would like to bump this patch set. I also need these features from > libnotmuch. Currently there is no way to recover from Xapian errors, > which is pretty limiting. > > If it is the flush/commit that is the issue, I would be happy to make an > updated patch set. Hi Michael; Right, we should use the current name of 'commit'. We also need some way to check the xapian version in the configure script, and to make sure the right name is supported. Jani refers to id:1350487737-32058-2-git-send-email-bgamari.foss@gmail.com farther up the thread as having some relevant code/ideas. I think it's reasonable to require Xapian version at least 1.2.0, so that might simplify the configuration check. The other thing I wondered is if the error handling in these routines is as good as it could be. I guess it isn't worse than what is there, but especially since you are explicitly wanting to handle error conditions, it would be good to think if we can do something better than adding yet another printf to the library. d