From: David Bremner <david@tethera.net>
To: Michael Forney <mforney@mforney.org>,
Adrien Bustany <adrien@bustany.org>,
notmuch@notmuchmail.org
Subject: Re: [PATCH v2 0/2] Add flush/reopen methods to notmuch_database_t
Date: Wed, 26 Dec 2012 23:23:50 -0400 [thread overview]
Message-ID: <878v8kqit5.fsf@zancas.localnet> (raw)
In-Reply-To: <1355276420-ner-1510@novus>
Michael Forney <mforney@mforney.org> writes:
> On Thu, 18 Oct 2012 00:52:20 +0300, Adrien Bustany <adrien@bustany.org> wrote:
>> The code of the patches in unchanged, but the formatting issues are now
>> hopefully fixed.
>
> I would like to bump this patch set. I also need these features from
> libnotmuch. Currently there is no way to recover from Xapian errors,
> which is pretty limiting.
>
> If it is the flush/commit that is the issue, I would be happy to make an
> updated patch set.
Hi Michael;
Right, we should use the current name of 'commit'. We also need some way
to check the xapian version in the configure script, and to make sure
the right name is supported.
Jani refers to
id:1350487737-32058-2-git-send-email-bgamari.foss@gmail.com
farther up the thread as having some relevant code/ideas.
I think it's reasonable to require Xapian version at least 1.2.0, so
that might simplify the configuration check.
The other thing I wondered is if the error handling in these routines is
as good as it could be. I guess it isn't worse than what is there, but
especially since you are explicitly wanting to handle error conditions,
it would be good to think if we can do something better than adding yet
another printf to the library.
d
prev parent reply other threads:[~2012-12-27 3:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 18:43 [PATCH 0/2] Add flush/reopen methods to notmuch_database_t Adrien Bustany
2012-07-19 18:43 ` [PATCH 1/2] Add notmuch_database_flush method Adrien Bustany
2012-10-17 15:53 ` Ethan Glasser-Camp
2012-10-17 21:34 ` Adrien Bustany
2012-07-19 18:43 ` [PATCH 2/2] Add notmuch_database_reopen method Adrien Bustany
2012-10-17 21:52 ` [PATCH v2 0/2] Add flush/reopen methods to notmuch_database_t Adrien Bustany
2012-10-17 21:52 ` [PATCH 1/2] Add notmuch_database_flush method Adrien Bustany
2012-10-17 21:52 ` [PATCH 2/2] Add notmuch_database_reopen method Adrien Bustany
2012-10-19 3:19 ` [PATCH v2 0/2] Add flush/reopen methods to notmuch_database_t Ethan Glasser-Camp
2012-10-19 7:19 ` Jani Nikula
2012-10-20 15:49 ` Ethan Glasser-Camp
2012-10-25 18:39 ` Adrien Bustany
2012-12-12 1:40 ` Michael Forney
2012-12-27 3:23 ` David Bremner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878v8kqit5.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=adrien@bustany.org \
--cc=mforney@mforney.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).