From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 4647B431FD7 for ; Sat, 24 Aug 2013 03:59:28 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id L8cDOJHbhXR9 for ; Sat, 24 Aug 2013 03:59:19 -0700 (PDT) Received: from mail-bk0-f46.google.com (mail-bk0-f46.google.com [209.85.214.46]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 9E83F431FBD for ; Sat, 24 Aug 2013 03:59:19 -0700 (PDT) Received: by mail-bk0-f46.google.com with SMTP id 6so560434bkj.33 for ; Sat, 24 Aug 2013 03:59:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-gm-message-state:from:to:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-type; bh=tGB+tZUWFjxNfCnJz91kgJpQLj7C4DE+rcrn1sFxmzo=; b=NmhFVyiZ60XJC2Z+0tfpRPTpIViMjUVw4p3HWlWik+OtLqYnkjM3U26r+mGwr7HDfz nStSIJZi4+kGJtnKvQVgUWhnwMdosVjoJgYOEQvU1MnZun2TUoCGWJk1gnbYjFu02sq2 fgXwVxX15oEzmkD3YaaPJsbLNjwRLgfmD5xIEQBuVVBw2SystuULKDzUAFMphcRUG0ZE xcVA2TdBTId2GjjYtJTcg0GWPXoQzhxrWT6vJ+vqQJBTuS46ZLGgCWNNSiL3BeJR46Yc g8DGWV1Hxr4t7bP3Sz8zdZzRof2YBD/cGitQvcaYie9M5uYGuhIS0CgUCcDcTLnep8by kk9A== X-Gm-Message-State: ALoCoQnJC3P7Ek03v0In1kwM6gZ1zKpuWgakHfiAlaEDJzicFDqtJNGxLhp2L52UlOExEdsNg1Cz X-Received: by 10.204.69.12 with SMTP id x12mr2877894bki.14.1377341958283; Sat, 24 Aug 2013 03:59:18 -0700 (PDT) Received: from localhost (dsl-hkibrasgw2-58c36f-91.dhcp.inet.fi. [88.195.111.91]) by mx.google.com with ESMTPSA id jh13sm817908bkb.13.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 24 Aug 2013 03:59:17 -0700 (PDT) From: Jani Nikula To: Tomi Ollila , John Lenz , notmuch@notmuchmail.org Subject: Re: cli: add --include-html option to notmuch show In-Reply-To: References: <87k3jjutpf.fsf@nikula.org> User-Agent: Notmuch/0.16+10~g791e68f (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Sat, 24 Aug 2013 13:59:20 +0300 Message-ID: <878uzrnylz.fsf@nikula.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Aug 2013 10:59:28 -0000 On Sun, 18 Aug 2013, Tomi Ollila wrote: > Now, if we have --include-html should it be like that or > --include-html=(true|false). Currently we have both cases, adding > --verify, --decrypt, --create-folder, --batch, -no-hooks to the > set... I cannot get a clear opinion (without wast^H^H^H^H spending > excessive amount of time figuring these out) how this should be, > therefore I'm inclined to the opinion that > > the current patch from John with simple --include-html could be applied, > and in the future (if it is of anyone's interest) we update the parser > allowing boolean --arg equal --arg=true. Then it is just how we decide > to document these... The argument parser we have allows NOTMUCH_OPT_BOOLEAN options to be specified as --foo=(true|false) or simply --foo (for true). It is already now just a matter of documentation, and I'm sure we're not consistent. We also have things like --no-hooks in notmuch new. I added that, and in retrospect, that should be just --hooks=(true|false). I guess we left it like that because the default is true. Perhaps we should amend the argument parser to look for boolean option --foo if it encounters a --no-foo option. Why notmuch show has --exclude=(true|false) as a keyword option I don't quite grasp; the --entire-thread option at least has a special default. It might help some options if the parser had a way to tell if it's seen some option or not. Of course, none of this is really relevant to the patch in question! BR, Jani.