From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>,
Ben Gamari <bgamari.foss@gmail.com>,
notmuch@notmuchmail.org
Subject: Re: [PATCH 1/3] database: Add notmuch_database_compact_close
Date: Fri, 11 Oct 2013 12:15:37 -0300 [thread overview]
Message-ID: <878uxzq1nq.fsf@unb.ca> (raw)
In-Reply-To: <m2ob6xw4bw.fsf@guru.guru-group.fi>
Tomi Ollila <tomi.ollila@iki.fi> writes:
>
> From functionality point if view this looks safe to me.
> A followup patch could provide more information to the user
> is any of the following attemts fail, e.g.
>
> - if removing old database out of the way how to remove the new
> compacted database which can be considered as garbage now -- or
> how to rename it (which is a bit dangerous due to potential races)
>
> - if moving compacted database fails how to restore backup database...
> ... or how to move compacted database to where it was supposed to be
> moved so that database is usable...
>
> ... if the database is missing is new created from scratch, also in case
> there already is .notmuch directory ?
>
> ... should the database open try to open database from these alternative
> names in case opening from original name fails ?
>
> another, small change:
>
> case "${xapian_version}" in
> - 0.*|1.[01].*|1.2.[0-5])
> + 0.*|1.[01].*|1.2.[0-5]|1.2.[0-5][^0-9]*)
> printf "No (only available with Xapian > 1.2.6).\n" ;;
>
> someone might do version like 1.2.4-abc but probably not 1.2.04 (nor 1.2a.4)
>
> (side note: case $x in [^...]) works with bash (and ksh&zsh, but not with dash)
OK, let's leave those merged, and clean up these issues before the next
release.
d
next prev parent reply other threads:[~2013-10-11 15:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 20:30 [PATCH] notmuch compact support (v4) Ben Gamari
2013-10-02 20:30 ` [PATCH 1/3] database: Add notmuch_database_compact_close Ben Gamari
2013-10-10 15:09 ` Tomi Ollila
2013-10-11 15:15 ` David Bremner [this message]
2013-10-20 17:02 ` Tomi Ollila
2013-11-02 18:30 ` Jameson Graef Rollins
2013-10-02 20:30 ` [PATCH 2/3] notmuch-compact: Initial commit of CLI Ben Gamari
2013-10-02 20:30 ` [PATCH 3/3] notmuch-compact: Add man page Ben Gamari
2013-10-10 10:22 ` [PATCH] notmuch compact support (v4) David Bremner
2013-10-10 12:01 ` Ben Gamari
-- strict thread matches above, loose matches on Subject: below --
2013-08-24 2:55 Ben Gamari
2013-08-24 2:55 ` [PATCH 1/3] database: Add notmuch_database_compact_close Ben Gamari
2013-09-01 15:43 ` Jani Nikula
2013-09-03 14:32 ` Ben Gamari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878uxzq1nq.fsf@unb.ca \
--to=david@tethera.net \
--cc=bgamari.foss@gmail.com \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).