From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 99C07429E32 for ; Sat, 16 Nov 2013 15:00:59 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0WQqk-quVUbQ for ; Sat, 16 Nov 2013 15:00:55 -0800 (PST) Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 7591E429E30 for ; Sat, 16 Nov 2013 15:00:55 -0800 (PST) Received: from remotemail by yantan.tethera.net with local (Exim 4.80) (envelope-from ) id 1VhorD-0005Sq-73; Sat, 16 Nov 2013 19:00:51 -0400 Received: (nullmailer pid 29533 invoked by uid 1000); Sat, 16 Nov 2013 23:00:47 -0000 From: David Bremner To: Jameson Graef Rollins , Daniel Kahn Gillmor , notmuch Subject: Re: fix for failing tests with gmime 2.6.19 In-Reply-To: <87iovsxfu0.fsf@servo.finestructure.net> References: <1384100482-15453-1-git-send-email-david@tethera.net> <52805350.70004@fifthhorseman.net> <87iovzywua.fsf@zancas.localnet> <87iovzvyui.fsf@zancas.localnet> <87iovsxfu0.fsf@servo.finestructure.net> User-Agent: Notmuch/0.16+167~g9838fe8 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Sat, 16 Nov 2013 19:00:47 -0400 Message-ID: <878uwoymsg.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Nov 2013 23:00:59 -0000 Jameson Graef Rollins writes: > I agree with Daniel that the original series adds a whole lot of > undesirable cruft to the test suite to get around one transient issue in > one of the notmuch dependencies. That doesn't seem like the best thing > to do imho. I would vote for this option instead, which doesn't modify > the test suite and just skips the affected tests until the new gmime > versions falls through everywhere. FWIW, it does modify the test suite. The patch-which-no-one-wrote-yet-but-probably-isn't-that-hard would have to change the test suite to not treat skipped tests as errors. I'm not sure whether that's a harmless change or not. Missing prerequisites also cause tests to be skipped, so in a sense this a change with more repercussions. d