From: David Bremner <david@tethera.net>
To: Jameson Graef Rollins <jrollins@finestructure.net>,
Daniel Kahn Gillmor <dkg@fifthhorseman.net>,
notmuch <notmuch@notmuchmail.org>
Subject: Re: fix for failing tests with gmime 2.6.19
Date: Sat, 16 Nov 2013 19:00:47 -0400 [thread overview]
Message-ID: <878uwoymsg.fsf@zancas.localnet> (raw)
In-Reply-To: <87iovsxfu0.fsf@servo.finestructure.net>
Jameson Graef Rollins <jrollins@finestructure.net> writes:
> I agree with Daniel that the original series adds a whole lot of
> undesirable cruft to the test suite to get around one transient issue in
> one of the notmuch dependencies. That doesn't seem like the best thing
> to do imho. I would vote for this option instead, which doesn't modify
> the test suite and just skips the affected tests until the new gmime
> versions falls through everywhere.
FWIW, it does modify the test suite. The
patch-which-no-one-wrote-yet-but-probably-isn't-that-hard would have to
change the test suite to not treat skipped tests as errors. I'm not
sure whether that's a harmless change or not. Missing prerequisites also
cause tests to be skipped, so in a sense this a change with more
repercussions.
d
next prev parent reply other threads:[~2013-11-16 23:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-10 16:21 fix for failing tests with gmime 2.6.19 David Bremner
2013-11-10 16:21 ` [PATCH 1/2] test: add optional workaround for gmime bug David Bremner
2013-11-10 16:21 ` [PATCH 2/2] test: work around gmime bug using notmuch_reply_sanitize David Bremner
2013-11-11 3:15 ` [Patch v2 1/2] test: add optional workaround for gmime bug David Bremner
2013-11-11 3:15 ` [Patch v2 2/2] test: work around gmime bug using notmuch_reply_sanitize David Bremner
2013-11-11 3:47 ` fix for failing tests with gmime 2.6.19 Daniel Kahn Gillmor
2013-11-11 11:57 ` David Bremner
2013-11-11 13:42 ` David Bremner
2013-11-16 20:16 ` Jameson Graef Rollins
2013-11-16 23:00 ` David Bremner [this message]
2013-11-11 14:59 ` Tomi Ollila
2013-11-11 16:01 ` Jani Nikula
2013-11-18 17:54 ` Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878uwoymsg.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=dkg@fifthhorseman.net \
--cc=jrollins@finestructure.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).