From: Jani Nikula <jani@nikula.org>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] emacs: hello: bugfix: make alphabetically sorted saved searches work
Date: Sat, 12 Apr 2014 13:50:02 +0300 [thread overview]
Message-ID: <878ura7rfp.fsf@nikula.org> (raw)
In-Reply-To: <1397292033-26502-1-git-send-email-markwalters1009@gmail.com>
On Sat, 12 Apr 2014, Mark Walters <markwalters1009@gmail.com> wrote:
> My recent changes to the saved search format broke the alphabetically
> sorted saved sort option. This makes it work again.
>
> Also, since the saved-search list is no longer an alist change the
> names in the sort function to avoid confusion.
> ---
> Thanks to Jani for pointing out the bug.
Looks good, works for me, thanks for the fix.
BR,
Jani.
>
> Best wishes
>
> Mark
>
> emacs/notmuch-hello.el | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
> index 4900a24..fca2bcc 100644
> --- a/emacs/notmuch-hello.el
> +++ b/emacs/notmuch-hello.el
> @@ -39,9 +39,12 @@ (defcustom notmuch-show-empty-saved-searches nil
> :type 'boolean
> :group 'notmuch-hello)
>
> -(defun notmuch-sort-saved-searches (alist)
> - "Generate an alphabetically sorted saved searches alist."
> - (sort (copy-sequence alist) (lambda (a b) (string< (car a) (car b)))))
> +(defun notmuch-sort-saved-searches (saved-searches)
> + "Generate an alphabetically sorted saved searches list."
> + (sort (copy-sequence saved-searches)
> + (lambda (a b)
> + (string< (notmuch-saved-search-get a :name)
> + (notmuch-saved-search-get b :name)))))
>
> (defcustom notmuch-saved-search-sort-function nil
> "Function used to sort the saved searches for the notmuch-hello view.
> --
> 1.7.10.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
prev parent reply other threads:[~2014-04-12 10:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-12 8:40 [PATCH 1/2] emacs: hello: bugfix: make alphabetically sorted saved searches work Mark Walters
2014-04-12 8:40 ` [PATCH 2/2] NEWS: document possible breakage from saved-search format change Mark Walters
2014-04-12 8:51 ` [PATCH] emacs: hello: update docs for saved-search sort defcustom Mark Walters
2014-04-12 10:50 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878ura7rfp.fsf@nikula.org \
--to=jani@nikula.org \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).